Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1571 fix spack package pipeline #1573

Merged
merged 1 commit into from
Oct 5, 2021
Merged

#1571 fix spack package pipeline #1573

merged 1 commit into from
Oct 5, 2021

Conversation

jstrzebonski
Copy link
Contributor

@jstrzebonski jstrzebonski commented Oct 4, 2021 •
edited
Loading

Fixes #1571

What was done:

  1. Use fixed version of spack (v0.16.3)
  2. Convert env variables into boolean variants, that are expected after implementing Boolean variants for options? spack-package#12

@jstrzebonski jstrzebonski self-assigned this Oct 4, 2021
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (gcc-5, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (clang-3.9, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (clang-5.0, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (gcc-6, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (clang-9, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (clang-10, alpine, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (clang-10, ubuntu, mpich)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 9ec25d8

Compilation - successful

Testing - passed

Build log

@jstrzebonski jstrzebonski marked this pull request as ready for review October 5, 2021 15:03
@jstrzebonski jstrzebonski marked this pull request as draft October 5, 2021 15:08
@jstrzebonski jstrzebonski requested review from cz4rs, JacobDomagala and lifflander and removed request for PhilMiller, lifflander, cz4rs, nmm0 and JacobDomagala October 5, 2021 15:08
@jstrzebonski jstrzebonski marked this pull request as ready for review October 5, 2021 15:16
cz4rs
cz4rs approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

lifflander
lifflander approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jstrzebonski jstrzebonski merged commit f7c93ee into develop Oct 5, 2021
@lifflander lifflander mentioned this pull request Oct 5, 2021
Open
@JacobDomagala JacobDomagala mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@nmm0 nmm0 Awaiting requested review from nmm0

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@ppebay ppebay Awaiting requested review from ppebay

Assignees

@jstrzebonski jstrzebonski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline PR tests spack-package (gcc-10, ubuntu, openmpi, no LB, spack-package) fails to build develop
3 participants
@jstrzebonski @lifflander @cz4rs