1660 Associate proxy with chain set to track automatically #1664

lifflander · 2022-01-28T00:42:04Z

github-actions · 2022-01-28T00:55:03Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T00:57:22Z

PR tests (gcc-6, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T00:58:34Z

PR tests (gcc-5, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T00:58:37Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T00:59:55Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T01:01:19Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T01:05:41Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T01:08:21Z

PR tests (clang-9, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T01:08:57Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T01:11:46Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

codecov · 2022-01-28T01:15:43Z

Codecov Report

Merging #1664 (746ebf0) into develop (e906fc0) will decrease coverage by 0.03%.
The diff coverage is 88.07%.

❗ Current head 746ebf0 differs from pull request most recent head 1af1cda. Consider uploading reports for the commit 1af1cda to get more accurate results

@@             Coverage Diff             @@
##           develop    #1664      +/-   ##
===========================================
- Coverage    83.58%   83.54%   -0.04%     
===========================================
  Files          799      799              
  Lines        31180    30941     -239     
===========================================
- Hits         26061    25851     -210     
+ Misses        5119     5090      -29

Impacted Files	Coverage Δ
src/vt/vrt/collection/holders/holder.h	`100.00% <ø> (ø)`
src/vt/messaging/collection_chain_set.h	`91.07% <37.50%> (-8.93%)`	⬇️
src/vt/messaging/collection_chain_set.impl.h	`77.77% <77.77%> (ø)`
src/vt/rdmahandle/manager.collection.impl.h	`98.38% <100.00%> (ø)`
src/vt/vrt/collection/holders/holder.impl.h	`93.24% <100.00%> (+0.28%)`	⬆️
src/vt/vrt/collection/manager.impl.h	`96.02% <100.00%> (+0.06%)`	⬆️
...t/termination/test_collection_chainset_tracking.cc	`100.00% <100.00%> (ø)`
tests/unit/termination/test_term_dep_send_chain.cc	`98.64% <100.00%> (-0.01%)`	⬇️
src/vt/collective/collective_ops.cc	`59.61% <0.00%> (-28.91%)`	⬇️
src/vt/registry/auto/auto_registry.cc	`58.62% <0.00%> (-6.90%)`	⬇️
... and 38 more

github-actions · 2022-01-28T01:15:46Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for c4fd27c

Build failed for unknown reason. Check build logs

Build log

github-actions · 2022-01-28T01:27:55Z

PR tests (clang-10, alpine, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

github-actions · 2022-01-28T01:31:36Z

PR tests (clang-10, ubuntu, mpich)

Build for 1af1cda

Compilation - successful

Testing - passed

Build log

src/vt/messaging/collection_chain_set.impl.h

PhilMiller · 2022-01-28T01:49:30Z

I'm impressed with how simple this turned out to be

src/vt/messaging/collection_chain_set.impl.h

PhilMiller · 2022-02-01T18:28:41Z

This all seems fine now.

lifflander requested review from PhilMiller and nmm0 January 28, 2022 00:42

PhilMiller reviewed Jan 28, 2022

View reviewed changes

src/vt/messaging/collection_chain_set.impl.h Show resolved Hide resolved

PhilMiller reviewed Jan 28, 2022

View reviewed changes

src/vt/messaging/collection_chain_set.impl.h Show resolved Hide resolved

PhilMiller reviewed Jan 28, 2022

View reviewed changes

src/vt/messaging/collection_chain_set.impl.h Outdated Show resolved Hide resolved

PhilMiller reviewed Feb 1, 2022

View reviewed changes

src/vt/messaging/collection_chain_set.impl.h Show resolved Hide resolved

lifflander force-pushed the 1660-associate-proxy-chain-set branch 2 times, most recently from 7bd3cf3 to c4fd27c Compare February 8, 2022 00:26

lifflander marked this pull request as ready for review February 9, 2022 01:28

lifflander added 5 commits March 7, 2022 13:37

#1660: vrt_coll: fix wrong type in assert

54abb80

#1660: vrt_coll: add home node to listener interface

c7c804c

#1660: chainset: allow collection proxies to be tracked automatically

7f8551b

#1660: chainset: fix logic, get existing indices, refactor

b3207d4

#1660: tests: make test use new interface

5af0c2d

lifflander added 3 commits March 7, 2022 13:37

#1660: chainset: another fix to the logic

d4153f4

#1660: tests: add a new chainset test

0e4cc1c

#1660: tests: add barriers to avoid race condition in test

1af1cda

lifflander force-pushed the 1660-associate-proxy-chain-set branch from c4fd27c to 1af1cda Compare March 7, 2022 21:38

lifflander requested a review from PhilMiller March 8, 2022 18:06

PhilMiller approved these changes Mar 8, 2022

View reviewed changes

lifflander merged commit fbdc1be into develop Mar 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1660 Associate proxy with chain set to track automatically #1664

1660 Associate proxy with chain set to track automatically #1664

lifflander commented Jan 28, 2022

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

codecov bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

PhilMiller commented Jan 28, 2022

PhilMiller commented Feb 1, 2022

1660 Associate proxy with chain set to track automatically #1664

1660 Associate proxy with chain set to track automatically #1664

Conversation

lifflander commented Jan 28, 2022

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

codecov bot commented Jan 28, 2022 • edited Loading

Codecov Report

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

github-actions bot commented Jan 28, 2022 • edited Loading

PhilMiller commented Jan 28, 2022

PhilMiller commented Feb 1, 2022

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

codecov bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading

github-actions bot commented Jan 28, 2022 •

edited

Loading