1484: fix memory footprint tests #1676

cz4rs · 2022-02-15T18:55:20Z

github-actions · 2022-02-15T19:54:06Z

PR tests (gcc-5, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:03:36Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:04:00Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:13:07Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:21:39Z

PR tests (gcc-6, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:25:23Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:30:35Z

PR tests (clang-9, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:34:56Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:35:44Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:44:04Z

PR tests (clang-10, alpine, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:47:08Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

github-actions · 2022-02-15T20:59:33Z

PR tests (clang-10, ubuntu, mpich)

Build for 22dfbb8

Compilation - successful

Testing - passed

Build log

codecov · 2022-03-02T19:44:47Z

Codecov Report

Merging #1676 (22dfbb8) into develop (6316827) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1676      +/-   ##
===========================================
- Coverage    83.79%   83.70%   -0.10%     
===========================================
  Files          772      772              
  Lines        26868    26772      -96     
===========================================
- Hits         22514    22409     -105     
- Misses        4354     4363       +9

Impacted Files	Coverage Δ
src/vt/rdma/state/rdma_state.h	`33.33% <ø> (ø)`
src/vt/runtime/component/component_pack.h	`100.00% <ø> (ø)`
src/vt/runtime/runtime_banner.cc	`64.85% <100.00%> (ø)`
tests/unit/runtime/test_memory_footprint.cc	`100.00% <100.00%> (ø)`
...c/vt/vrt/collection/balance/stats_restart_reader.h	`40.00% <0.00%> (-60.00%)`	⬇️
src/vt/runtime/runtime_get.cc	`83.78% <0.00%> (-16.22%)`	⬇️

cz4rs · 2022-03-08T14:28:56Z

a0f5b9a adds seemingly reasonable test verifying that passthru_args vector is empty after initialization. This fails on gcc-6 build (and passes fine everywhere else), where the only meaningful difference is that unity build is disabled.

Note: I was able to reproduce this locally with clang 13, so definitely not a compiler issue.

cz4rs · 2022-03-15T11:35:13Z

In the end, this PR is addressing 2 issues:

function pointers being dereferenced during serialization (fixed by using countBytes)
header issue described in including app_config.h crashes applications #1702 (fixed by removing majority of includes)

Other changes are a small cleanup, updating workflow definitions and removing tests performing footprinting of single components (these did not add much value, since the coverage is provided by testing Runtime::printMemoryFootprint()).

Disable unity build in gcc-6 workflow and update all workflows.

This reverts commit 5f91b78.

Remove separate tests for each component. Footprinting is performed for all (live) components in `test_live_components` and `test_live_components_at_shutdown`.

cz4rs force-pushed the 1484-fix-memory-footprint-tests branch from ecd604f to 40e4ef1 Compare February 15, 2022 18:57

This comment was marked as outdated.

Sign in to view

cz4rs force-pushed the 1484-fix-memory-footprint-tests branch 2 times, most recently from 81ec62e to 7ab383b Compare February 28, 2022 14:09

cz4rs force-pushed the 1484-fix-memory-footprint-tests branch from 3c4bb4c to d04e3fc Compare March 2, 2022 19:07

cz4rs force-pushed the 1484-fix-memory-footprint-tests branch 3 times, most recently from ebe33cb to 827bbf9 Compare March 7, 2022 13:20

cz4rs force-pushed the 1484-fix-memory-footprint-tests branch 3 times, most recently from ca13bd7 to 1153f9d Compare March 14, 2022 13:14

cz4rs marked this pull request as ready for review March 15, 2022 11:28

cz4rs requested review from jstrzebonski, lifflander, JacobDomagala and nlslatt March 15, 2022 11:29

cz4rs requested review from nmm0 and PhilMiller March 15, 2022 11:29

PhilMiller approved these changes Mar 15, 2022

View reviewed changes

lifflander mentioned this pull request Mar 15, 2022

Meeting Agenda [do not close] #925

Open

cz4rs added 9 commits March 15, 2022 15:25

#1484: remove obsolete declaration

f70e973

#1484: tests: remove ArgConfig footprinting test

dca5054

#1484: CI: set gcc-6 build as non-unity

0ecb537

Disable unity build in gcc-6 workflow and update all workflows.

#1484: use simplified footprinting for function pointers

d5fe161

#1484: Revert: tests: remove ArgConfig footprinting test

343c0a9

This reverts commit 5f91b78.

#1484: tests: check passthru args after initialization

130e034

#1484: remove duplicated footprinting tests

2d90628

Remove separate tests for each component. Footprinting is performed for all (live) components in `test_live_components` and `test_live_components_at_shutdown`.

#1484: remove redundant condition

b9a16b3

#1484: tests: remove non-essential includes

22dfbb8

PhilMiller force-pushed the 1484-fix-memory-footprint-tests branch from a848af8 to 22dfbb8 Compare March 15, 2022 22:26

PhilMiller merged commit 424bc61 into develop Mar 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1484: fix memory footprint tests #1676

1484: fix memory footprint tests #1676

cz4rs commented Feb 15, 2022

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

This comment was marked as outdated.

github-actions bot commented Feb 15, 2022 •

edited

Loading

codecov bot commented Mar 2, 2022 •

edited

Loading

cz4rs commented Mar 8, 2022

cz4rs commented Mar 15, 2022

1484: fix memory footprint tests #1676

1484: fix memory footprint tests #1676

Conversation

cz4rs commented Feb 15, 2022

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

This comment was marked as outdated.

github-actions bot commented Feb 15, 2022 • edited Loading

codecov bot commented Mar 2, 2022 • edited Loading

Codecov Report

cz4rs commented Mar 8, 2022

cz4rs commented Mar 15, 2022

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

codecov bot commented Mar 2, 2022 •

edited

Loading