1677: dont rerun cmake for git ref #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1683 +/- ##
===========================================
+ Coverage 83.42% 83.46% +0.03%
===========================================
Files 799 799
Lines 30934 30934
===========================================
+ Hits 25807 25819 +12
+ Misses 5127 5115 -12
|
PhilMiller
reviewed
Feb 22, 2022
PhilMiller
reviewed
Feb 22, 2022
PhilMiller
reviewed
Feb 22, 2022
PhilMiller
reviewed
Feb 23, 2022
PhilMiller
reviewed
Feb 23, 2022
… empty if not on a named branch
…he git repository directory
nmm0
force-pushed
the
1677-dont-rerun-cmake-for-git-ref
branch
from
1dbf89a to
6803ce6
Compare
cz4rs
approved these changes
Mar 1, 2022
Merged
PhilMiller
approved these changes
Mar 1, 2022
cz4rs
pushed a commit
that referenced
this pull request
Mar 1, 2022
…-git-ref 1677: dont rerun cmake for git ref
cz4rs
pushed a commit
that referenced
this pull request
Mar 1, 2022
…-git-ref 1677: dont rerun cmake for git ref
cz4rs
pushed a commit
that referenced
this pull request
Mar 4, 2022
…-git-ref 1677: dont rerun cmake for git ref
cz4rs
pushed a commit
that referenced
this pull request
Mar 4, 2022
…-git-ref 1677: dont rerun cmake for git ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1677
This PR uses
add_custom_commandto act as a source file generator forsrc/vt/configs/generated/vt_git_revision.cc. It runs a cmake script (adapted from the earlier script) when any of:.git/HEAD,.git/packed-refsor.git/refs/<named-branch-ref>are modified. If they are modified, only vt_git_revision.cc will be rebuilt, and VT will need to be relinked. This will happen automatically. This avoids re-running cmake multiple times for no reason.This additionally works correctly if a new branch was made and other changes to git occur.