1423 remove maximimum ref-count check

[stmcgovern]

Fixes #1423 by simply removing the upper bound check in the assertion.
Alternative to PR #1432

[codecov]

Codecov Report

Merging #1712 (7fc5f64) into develop (feaa148) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 7fc5f64 differs from pull request most recent head c85f1bb. Consider uploading reports for the commit c85f1bb to get more accurate results

@@           Coverage Diff            @@
##           develop    #1712   +/-   ##
========================================
  Coverage    83.79%   83.79%           
========================================
  Files          773      773           
  Lines        26869    26894   +25     
========================================
+ Hits         22515    22537   +22     
- Misses        4354     4357    +3     

Impacted Files	Coverage Δ
src/vt/messaging/envelope/envelope_ref.impl.h	85.71% <50.00%> (-14.29%)	⬇️
src/vt/objgroup/manager.cc	80.28% <0.00%> (-9.01%)	⬇️
src/vt/objgroup/proxy/proxy_bits.cc	79.31% <0.00%> (-4.03%)	⬇️
.../vt/vrt/collection/balance/lb_invoke/lb_manager.cc	75.11% <0.00%> (-1.10%)	⬇️
src/vt/objgroup/manager.h	100.00% <0.00%> (ø)
src/vt/pipe/callback/callback_base.h	100.00% <0.00%> (ø)
src/vt/objgroup/proxy/proxy_objgroup.h	100.00% <0.00%> (ø)
src/vt/registry/auto/auto_registry_impl.h	100.00% <0.00%> (ø)
src/vt/objgroup/proxy/proxy_objgroup.impl.h	100.00% <0.00%> (ø)
...c/vt/vrt/collection/balance/lb_invoke/lb_manager.h	100.00% <0.00%> (ø)
... and 5 more

[github-actions]

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-5, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-5.0, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-3.9, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-6, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-9, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-10, alpine, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-10, ubuntu, mpich)

Build for c85f1bb

Compilation - successful

Testing - passed

Build log

[stmcgovern]

Line 65 comment should be amended to "Message ref-count must never be negative."

[lifflander]

Looks good to me! Just need to get the warnings worked out.

[PhilMiller]

Code looks fine to me.

[stmcgovern]

Looks good to me! Just need to get the warnings worked out.

• They seem to be related to type conversions (mostly in pipe manager) only when using cuda.
• Here in /vt/src/vt/configs/types/types_sentinels.h(78): warning: integer conversion resulted in a change of sign
  static constexpr RefType const not_shared_message = -1000;
  Since that RefType is now uint16 initializing to -1000 no longer makes sense, right?