1723 Include user-defined fields in json LB data files #1728

nlslatt · 2022-04-01T18:10:30Z

This PR adds the ability to dump items stored in collection elements as user-defined data in LB data json files. I also added a commit that removes some stale lines of code from an existing unit test.

Closes #1723

github-actions · 2022-04-01T18:17:46Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:19:06Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:26:25Z

PR tests (clang-9, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:26:30Z

PR tests (gcc-5, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:27:20Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:27:28Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:28:16Z

PR tests (gcc-6, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T18:30:50Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

codecov · 2022-04-01T18:53:58Z

Codecov Report

Merging #1728 (7ccdfaa) into develop (25937dd) will decrease coverage by 0.81%.
The diff coverage is 96.05%.

❗ Current head 7ccdfaa differs from pull request most recent head 7759537. Consider uploading reports for the commit 7759537 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1728      +/-   ##
===========================================
- Coverage    84.65%   83.83%   -0.82%     
===========================================
  Files          774      773       -1     
  Lines        27026    26965      -61     
===========================================
- Hits         22879    22607     -272     
- Misses        4147     4358     +211

Impacted Files	Coverage Δ
src/vt/messaging/active.cc	`86.65% <ø> (ø)`
src/vt/vrt/collection/balance/node_stats.h	`100.00% <ø> (ø)`
src/vt/vrt/collection/types/storage/storable.h	`0.00% <ø> (ø)`
src/vt/vrt/collection/types/storage/store_elm.h	`90.62% <78.57%> (+1.15%)`	⬆️
src/vt/objgroup/manager.cc	`80.28% <100.00%> (-9.01%)`	⬇️
src/vt/vrt/collection/balance/col_stats.impl.h	`100.00% <100.00%> (ø)`
src/vt/vrt/collection/balance/node_stats.cc	`80.17% <100.00%> (ø)`
src/vt/vrt/collection/balance/stats_data.cc	`89.26% <100.00%> (ø)`
src/vt/vrt/collection/balance/stats_data.h	`100.00% <100.00%> (ø)`
src/vt/vrt/collection/types/storage/storable.cc	`100.00% <100.00%> (ø)`
... and 77 more

github-actions · 2022-04-01T19:06:26Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T19:10:38Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T19:11:59Z

PR tests (clang-10, alpine, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T19:16:12Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-04-01T19:32:36Z

PR tests (clang-10, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

src/vt/vrt/collection/balance/stats_data.h

lifflander · 2022-04-05T18:13:42Z

Overall, looks great!

lifflander

Looks good to me!

lifflander

Looks good to me!

github-actions · 2022-04-28T23:08:25Z

PR tests (clang-11, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-04-28T23:15:53Z

PR tests (intel icpx, ubuntu, mpich)

Build for 7759537

/vt/lib/EngFormat-Cpp/src/eng_format.cpp:144:15: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    if      ( std::isnan( value ) ) return "NaN";
              ^~~~~~~~~~~~~~~~~~~
/vt/lib/EngFormat-Cpp/src/eng_format.cpp:145:15: warning: comparison with infinity always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    else if ( std::isinf( value ) ) return "INFINITE";
              ^~~~~~~~~~~~~~~~~~~
2 warnings generated.
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Testing - passed

Build log

github-actions · 2022-05-02T17:52:25Z

PR tests (clang-13, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-02T17:52:44Z

PR tests (clang-12, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-02T18:09:23Z

PR tests (clang-14, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-02T18:10:25Z

PR tests (gcc-11, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59,
                 from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

github-actions · 2022-05-02T18:57:38Z

PR tests (gcc-12, ubuntu, mpich)

Build for 7759537

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~
In file included from src/CMakeFiles/vt.dir/Unity/unity_2_cxx.cxx:10:
/vt/src/vt/group/region/group_list.cc: In member function 'virtual void vt::group::region::List::splitN(int, vt::group::region::Region::ApplyFnType) const':
/vt/src/vt/group/region/group_list.cc:164:31: warning: dangling pointer to an unnamed temporary may be used [-Wdangling-pointer=]
  164 |     for (int i = cur_idx; i < cur_max; i++) {
      |                               ^~~~~~~
/vt/src/vt/group/region/group_list.cc:162:22: note: unnamed temporary defined here
  162 |       size : std::min(size, cur_idx + child_size);
      |              ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Testing - passed

Build log

nlslatt requested review from PhilMiller, lifflander, cz4rs, nmm0, JacobDomagala and jstrzebonski April 1, 2022 18:10

nlslatt requested a review from stmcgovern April 5, 2022 17:24

nlslatt mentioned this pull request Apr 5, 2022

Meeting Agenda [do not close] #925

Open

lifflander requested changes Apr 5, 2022

View reviewed changes

src/vt/vrt/collection/balance/stats_data.h Outdated Show resolved Hide resolved

nlslatt requested a review from lifflander April 6, 2022 17:51

lifflander approved these changes Apr 6, 2022

View reviewed changes

lifflander self-requested a review April 12, 2022 17:38

lifflander approved these changes Apr 12, 2022

View reviewed changes

nlslatt force-pushed the 1723-include-user-defined-in-json branch from 7ccdfaa to 6376c04 Compare April 28, 2022 22:36

nlslatt added 13 commits May 2, 2022 08:56

#1723: storage: add bool to flag for json dump

94941ed

#1723: storage: add conversion to json

5681747

#1723: nodelbdata: pass storage for dumping to json

9e32241

#1723: nodelbdata: store and dump user-defined json

3a78e54

#1723: storage: disable jsoning ctor for non-jsonable

e7c75d1

#1723: storage: disable conversion when not jsonable

b43372d

#1723: storage: make whether to json non-virtual

28a9536

#1723: lbdataholder: omit user-defined from json if none provided

ddca909

#1723: tests: add tests for dumping user-defined

1131780

#1723: tests: clean up unused code in test

1ec31bc

#1723: storage: fix compile on clang

265e571

#1723: lbdataholder: avoid using big include

ff3c358

#1723: update from stats to lb data

7759537

nlslatt force-pushed the 1723-include-user-defined-in-json branch from 6376c04 to 7759537 Compare May 2, 2022 15:56

nlslatt merged commit ff3f2fa into develop May 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1723 Include user-defined fields in json LB data files #1728

1723 Include user-defined fields in json LB data files #1728

nlslatt commented Apr 1, 2022

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

codecov bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

lifflander commented Apr 5, 2022

lifflander left a comment

lifflander left a comment

github-actions bot commented Apr 28, 2022 •

edited

Loading

github-actions bot commented Apr 28, 2022 •

edited

Loading

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

1723 Include user-defined fields in json LB data files #1728

1723 Include user-defined fields in json LB data files #1728

Conversation

nlslatt commented Apr 1, 2022

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

codecov bot commented Apr 1, 2022 • edited Loading

Codecov Report

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

github-actions bot commented Apr 1, 2022 • edited Loading

lifflander commented Apr 5, 2022

lifflander left a comment

Choose a reason for hiding this comment

lifflander left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 28, 2022 • edited Loading

github-actions bot commented Apr 28, 2022 • edited Loading

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented May 2, 2022

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

codecov bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022 •

edited

Loading

github-actions bot commented Apr 28, 2022 •

edited

Loading

github-actions bot commented Apr 28, 2022 •

edited

Loading