Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1736: Fix tests defined in headers #1738

Merged
merged 4 commits into from
Apr 19, 2022
Merged

1736: Fix tests defined in headers #1738

merged 4 commits into from
Apr 19, 2022
+122 −34

Conversation

JacobDomagala
Copy link
Contributor

Fixes #1736

@JacobDomagala
#1736: Tests: Move test body of test_collection_send_ptm_1 and test_c…
f9faae3 
…ollection_send_1 to separate functions and then use them in corresponding .cc files for both test_send.cc and test_send.extended.cc
@JacobDomagala
#1736: Tests: Move test body of test_rdma_handle_* to separate functi…
26a8ae0 
…ons and then use them in corresponding .cc files for both test_rdma_handle.cc and test_rdma_handle.extended.cc
@JacobDomagala
#1736: Tests: Move test body of test_broadcst_1 to separate function …
d3e4ce0 
…and then use it in corresponding .cc files for both test_broadcast.cc and test_broadcast.extended.cc
@JacobDomagala
#1736: Tests: Move test body of test_construct_1 and test_construct_d…
ab48080 
…istributed_1 to separate functions and then use them in corresponding .cc files for both test_construct.cc and test_construct_no_idx.extended.cc
@github-actions
Copy link

PR tests (clang-3.9, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (gcc-5, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (gcc-6, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (clang-5.0, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1738 (ab48080) into develop (f331718) will increase coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1738      +/-   ##
===========================================
+ Coverage    83.85%   84.65%   +0.80%     
===========================================
  Files          773      774       +1     
  Lines        26960    27026      +66     
===========================================
+ Hits         22607    22879     +272     
+ Misses        4353     4147     -206
Impacted Files Coverage Δ
tests/unit/collection/test_broadcast.cc 100.00% <100.00%> (ø)
tests/unit/collection/test_broadcast.extended.cc 100.00% <100.00%> (ø)
tests/unit/collection/test_broadcast.h 100.00% <100.00%> (+92.30%) ⬆️
...unit/collection/test_collection_construct_common.h 100.00% <100.00%> (+72.72%) ⬆️
tests/unit/collection/test_construct.cc 100.00% <100.00%> (+33.33%) ⬆️
.../unit/collection/test_construct_no_idx.extended.cc 100.00% <100.00%> (+33.33%) ⬆️
tests/unit/collection/test_send.cc 100.00% <100.00%> (ø)
tests/unit/collection/test_send.extended.cc 100.00% <100.00%> (ø)
tests/unit/collection/test_send.h 100.00% <100.00%> (+91.66%) ⬆️
tests/unit/rdma/test_rdma_handle.cc 100.00% <100.00%> (ø)
... and 18 more

@github-actions
Copy link

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (clang-9, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (clang-10, alpine, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

PR tests (clang-10, ubuntu, mpich)

Build for ab48080

Compilation - successful

Testing - passed

Build log

@JacobDomagala JacobDomagala marked this pull request as ready for review April 18, 2022 20:15
nlslatt
nlslatt approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

cz4rs
cz4rs approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jstrzebonski
jstrzebonski approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lifflander lifflander merged commit 3e362c4 into develop Apr 19, 2022
@lifflander lifflander mentioned this pull request Apr 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander

@cz4rs cz4rs

@jstrzebonski jstrzebonski

@nlslatt nlslatt

@nmm0 nmm0

@PhilMiller PhilMiller

@stmcgovern stmcgovern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests defined in header files are not run by ctest
5 participants
@JacobDomagala @lifflander @cz4rs @jstrzebonski @nlslatt