#1715 allow labels on object groups and collections #1754

jstrzebonski · 2022-05-02T20:21:49Z

src/vt/vrt/collection/param/construct_params.h

src/vt/vrt/collection/manager.h

codecov · 2022-05-10T21:35:19Z

Codecov Report

Merging #1754 (c6c6d25) into develop (c1b5f62) will increase coverage by 0.08%.
The diff coverage is 99.60%.

@@             Coverage Diff             @@
##           develop    #1754      +/-   ##
===========================================
+ Coverage    84.23%   84.32%   +0.08%     
===========================================
  Files          757      757              
  Lines        26611    26685      +74     
===========================================
+ Hits         22416    22502      +86     
+ Misses        4195     4183      -12

Impacted Files	Coverage Δ
src/vt/objgroup/manager.cc	`89.28% <ø> (ø)`
...c/vt/vrt/collection/balance/lb_invoke/lb_manager.h	`100.00% <ø> (ø)`
src/vt/vrt/collection/collection_builder.impl.h	`96.42% <ø> (ø)`
tests/unit/rdma/test_rdma_handle.h	`100.00% <ø> (ø)`
.../unit/rdma/test_rdma_static_sub_handle.extended.cc	`100.00% <ø> (ø)`
.../vt/vrt/collection/balance/lb_invoke/lb_manager.cc	`80.79% <91.66%> (+0.05%)`	⬆️
examples/callback/callback.cc	`100.00% <100.00%> (ø)`
examples/collection/insertable_collection.cc	`96.77% <100.00%> (ø)`
examples/collection/jacobi1d_vt.cc	`90.47% <100.00%> (ø)`
examples/collection/jacobi2d_vt.cc	`94.92% <100.00%> (ø)`
... and 70 more

src/vt/objgroup/manager.cc

src/vt/vrt/collection/manager.h

src/vt/vrt/collection/manager.impl.h

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc

nlslatt

Looks good!

nlslatt · 2022-06-01T20:29:07Z

Unfortunately, there are now merge conflicts. This can be merged once the conflicts are resolved.

jstrzebonski · 2022-06-02T10:39:51Z

Unfortunately, there are now merge conflicts. This can be merged once the conflicts are resolved.

@nlslatt
Rebased

jstrzebonski self-assigned this May 2, 2022

jstrzebonski requested review from lifflander, stmcgovern, nlslatt, cz4rs, JacobDomagala, nmm0 and PhilMiller May 2, 2022 20:26

jstrzebonski marked this pull request as ready for review May 2, 2022 20:26

lifflander reviewed May 2, 2022

View reviewed changes

src/vt/vrt/collection/param/construct_params.h Outdated Show resolved Hide resolved

jstrzebonski changed the title ~~1715 allow labels on object collections and groups~~ 1715 allow labels on object groups and collections May 4, 2022

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch 2 times, most recently from a50c489 to 7601a22 Compare May 6, 2022 18:28

jstrzebonski commented May 6, 2022

View reviewed changes

src/vt/vrt/collection/manager.h Outdated Show resolved Hide resolved

jstrzebonski commented May 6, 2022

View reviewed changes

src/vt/vrt/collection/manager.h Outdated Show resolved Hide resolved

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch from 7601a22 to f850e5b Compare May 9, 2022 13:14

jstrzebonski requested a review from lifflander May 9, 2022 13:15

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch from f850e5b to be045b7 Compare May 9, 2022 15:26

lifflander mentioned this pull request May 10, 2022

Meeting Agenda [do not close] #925

Open

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch from be045b7 to 99eb6bc Compare May 10, 2022 19:14

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch 2 times, most recently from 7beaf9a to fb020ce Compare May 11, 2022 19:05

lifflander previously requested changes May 11, 2022

View reviewed changes

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch from fb020ce to 3337172 Compare May 16, 2022 12:22

jstrzebonski requested a review from lifflander May 16, 2022 12:23

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch 3 times, most recently from 386741b to f452245 Compare May 17, 2022 17:25

jstrzebonski changed the title ~~1715 allow labels on object groups and collections~~ #1715 allow labels on object groups and collections May 17, 2022

DARMA-tasking deleted a comment from github-actions bot May 31, 2022

jstrzebonski commented May 31, 2022

View reviewed changes

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc Show resolved Hide resolved

jstrzebonski requested review from nlslatt and PhilMiller May 31, 2022 16:52

nlslatt approved these changes Jun 1, 2022

View reviewed changes

Jakub Strzebonski added 14 commits June 2, 2022 08:11

#1715 allow labels on collections

89da42a

#1715 allow labels on object groups

38e0c74

#1715 fix compilation after rebasing

b496f54

#1715 add proxy-to-label map

fc901ff

#1715 add unit test

a73fd3d

#1715 clean up implementation

0a609ab

#1715 make labels optional

c1ca5ee

#1715 delete objgroup label on destroy

4c4dbac

#1715 don't break deprecated interface

37a655c

#1715 keep collection's label in typeless holder

d23b0cb

#1715 when restoring collection from file, restore its label as well

167ee19

#1715 make label an optional argument for collection::constructMap()

a07c487

#1715 - rename labels

8683a9b

#1715 use lb_names_ to extract name of load balancer

c6c6d25

jstrzebonski force-pushed the 1715-allow-labels-on-object-collections-and-groups branch from 880d642 to c6c6d25 Compare June 2, 2022 06:18

nlslatt merged commit 4feceef into develop Jun 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1715 allow labels on object groups and collections #1754

#1715 allow labels on object groups and collections #1754

jstrzebonski commented May 2, 2022

codecov bot commented May 10, 2022 •

edited

Loading

nlslatt left a comment

nlslatt commented Jun 1, 2022

jstrzebonski commented Jun 2, 2022

#1715 allow labels on object groups and collections #1754

#1715 allow labels on object groups and collections #1754

Conversation

jstrzebonski commented May 2, 2022

codecov bot commented May 10, 2022 • edited Loading

Codecov Report

nlslatt left a comment

Choose a reason for hiding this comment

nlslatt commented Jun 1, 2022

jstrzebonski commented Jun 2, 2022

codecov bot commented May 10, 2022 •

edited

Loading