#1786: condition link flag on library's presence #1787

stmcgovern · 2022-05-09T15:06:21Z

Fixes #1786. Follow-up to issue #1691.

github-actions · 2022-05-09T15:09:30Z

PR tests (gcc-5, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:09:46Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:10:21Z

PR tests (gcc-6, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:10:52Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:10:56Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:10:58Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:11:53Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:11:58Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:14:08Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:14:10Z

PR tests (clang-11, ubuntu, mpich)

Build for 49aace0

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T15:14:22Z

PR tests (clang-12, ubuntu, mpich)

Build for 49aace0

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T15:14:51Z

PR tests (clang-10, alpine, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

codecov · 2022-05-09T15:21:15Z

Codecov Report

Merging #1787 (49aace0) into develop (892388b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1787      +/-   ##
===========================================
- Coverage    84.15%   84.14%   -0.01%     
===========================================
  Files          753      753              
  Lines        26127    26127              
===========================================
- Hits         21987    21985       -2     
- Misses        4140     4142       +2

Impacted Files	Coverage Δ
src/vt/messaging/request_holder.h	`69.23% <0.00%> (-7.70%)`	⬇️

github-actions · 2022-05-09T15:37:39Z

PR tests (clang-9, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:38:05Z

PR tests (intel icpx, ubuntu, mpich)

Build for 49aace0

/vt/lib/EngFormat-Cpp/src/eng_format.cpp:144:15: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    if      ( std::isnan( value ) ) return "NaN";
              ^~~~~~~~~~~~~~~~~~~
/vt/lib/EngFormat-Cpp/src/eng_format.cpp:145:15: warning: comparison with infinity always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    else if ( std::isinf( value ) ) return "INFINITE";
              ^~~~~~~~~~~~~~~~~~~
2 warnings generated.

Testing - passed

Build log

github-actions · 2022-05-09T15:41:07Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T15:41:15Z

PR tests (clang-13, ubuntu, mpich)

Build for 49aace0

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T15:41:52Z

PR tests (clang-14, ubuntu, mpich)

Build for 49aace0

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T15:43:02Z

PR tests (gcc-11, ubuntu, mpich)

Build for 49aace0

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59,
                 from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

github-actions · 2022-05-09T15:43:26Z

PR tests (gcc-12, ubuntu, mpich)

Build for 49aace0

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~
In file included from src/CMakeFiles/vt.dir/Unity/unity_2_cxx.cxx:10:
/vt/src/vt/group/region/group_list.cc: In member function 'virtual void vt::group::region::List::splitN(int, vt::group::region::Region::ApplyFnType) const':
/vt/src/vt/group/region/group_list.cc:164:31: warning: dangling pointer to an unnamed temporary may be used [-Wdangling-pointer=]
  164 |     for (int i = cur_idx; i < cur_max; i++) {
      |                               ^~~~~~~
/vt/src/vt/group/region/group_list.cc:162:22: note: unnamed temporary defined here
  162 |       size : std::min(size, cur_idx + child_size);
      |              ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Testing - passed

Build log

github-actions · 2022-05-09T15:52:39Z

PR tests (clang-10, ubuntu, mpich)

Build for 49aace0

Compilation - successful

Testing - passed

Build log

cz4rs

To make sure that this is working as intended, we could have one of the builds running without libunwind.
~~Maybe Alpine?~~ (edit: Alpine has to stick with libunwind)
Maybe Ubuntu/OpenMPI? Removing this line should be enough:

vt/ci/docker/ubuntu-20.04-gnu-openmpi-cpp.dockerfile

Line 31 in 00b1297

libunwind-dev \

Looks good otherwise 👍

stmcgovern · 2022-05-09T22:27:36Z

Thanks @cz4rs. Done.

lifflander

Looks good to me!

stmcgovern linked an issue May 9, 2022 that may be closed by this pull request

linking against libunwind when not present #1786

Closed

stmcgovern force-pushed the 1786-linking-against-libunwind-when-not-present branch from 0456635 to 7842ba2 Compare May 9, 2022 15:14

stmcgovern marked this pull request as ready for review May 9, 2022 15:18

cz4rs requested changes May 9, 2022

View reviewed changes

stmcgovern force-pushed the 1786-linking-against-libunwind-when-not-present branch from 7842ba2 to b662350 Compare May 9, 2022 21:51

stmcgovern requested a review from cz4rs May 9, 2022 22:27

lifflander self-requested a review May 9, 2022 22:48

lifflander approved these changes May 9, 2022

View reviewed changes

stmcgovern added 2 commits May 9, 2022 17:09

#1786: condition link flag on library's presence

260fd82

#1786: remove libunwind from ubuntu20-gnu-openmpi docker file

49aace0

lifflander force-pushed the 1786-linking-against-libunwind-when-not-present branch from b662350 to 49aace0 Compare May 10, 2022 00:09

cz4rs approved these changes May 10, 2022

View reviewed changes

lifflander merged commit 79eba5e into develop May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1786: condition link flag on library's presence #1787

#1786: condition link flag on library's presence #1787

stmcgovern commented May 9, 2022

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

codecov bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

cz4rs left a comment •

edited

Loading

stmcgovern commented May 9, 2022

lifflander left a comment

#1786: condition link flag on library's presence #1787

#1786: condition link flag on library's presence #1787

Conversation

stmcgovern commented May 9, 2022

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

codecov bot commented May 9, 2022 • edited Loading

Codecov Report

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022 • edited Loading

cz4rs left a comment • edited Loading

Choose a reason for hiding this comment

stmcgovern commented May 9, 2022

lifflander left a comment

Choose a reason for hiding this comment

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

codecov bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022 •

edited

Loading

cz4rs left a comment •

edited

Loading