1788 migrate collection test failure due to ds epochs #1789

lifflander · 2022-05-09T19:25:45Z

Fixes #1788

nlslatt

Looks good to me.

lifflander · 2022-05-09T19:40:47Z

The test is passing consistently on 16 nodes now. I've run it 1000 times. Seems to solve the problem entirely.

github-actions · 2022-05-09T20:19:33Z

PR tests (gcc-5, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:21:41Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:24:37Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:25:08Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:28:57Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:29:32Z

PR tests (gcc-6, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:29:32Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:30:09Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:30:34Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:32:46Z

PR tests (clang-9, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:33:36Z

PR tests (clang-10, alpine, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:34:23Z

PR tests (clang-11, ubuntu, mpich)

Build for 32d858f

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T20:34:47Z

PR tests (intel icpx, ubuntu, mpich)

Build for 32d858f

/vt/lib/EngFormat-Cpp/src/eng_format.cpp:144:15: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    if      ( std::isnan( value ) ) return "NaN";
              ^~~~~~~~~~~~~~~~~~~
/vt/lib/EngFormat-Cpp/src/eng_format.cpp:145:15: warning: comparison with infinity always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    else if ( std::isinf( value ) ) return "INFINITE";
              ^~~~~~~~~~~~~~~~~~~
2 warnings generated.

Testing - passed

Build log

github-actions · 2022-05-09T20:35:42Z

PR tests (clang-13, ubuntu, mpich)

Build for 32d858f

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T20:35:46Z

PR tests (clang-12, ubuntu, mpich)

Build for 32d858f

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T20:36:05Z

PR tests (clang-14, ubuntu, mpich)

Build for 32d858f

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

github-actions · 2022-05-09T20:36:28Z

PR tests (gcc-12, ubuntu, mpich)

Build for 32d858f

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~
In file included from src/CMakeFiles/vt.dir/Unity/unity_2_cxx.cxx:10:
/vt/src/vt/group/region/group_list.cc: In member function 'virtual void vt::group::region::List::splitN(int, vt::group::region::Region::ApplyFnType) const':
/vt/src/vt/group/region/group_list.cc:164:31: warning: dangling pointer to an unnamed temporary may be used [-Wdangling-pointer=]
  164 |     for (int i = cur_idx; i < cur_max; i++) {
      |                               ^~~~~~~
/vt/src/vt/group/region/group_list.cc:162:22: note: unnamed temporary defined here
  162 |       size : std::min(size, cur_idx + child_size);
      |              ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Testing - passed

Build log

github-actions · 2022-05-09T20:36:28Z

PR tests (gcc-11, ubuntu, mpich)

Build for 32d858f

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59,
                 from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

codecov · 2022-05-09T20:37:23Z

Codecov Report

Merging #1789 (32d858f) into develop (00b1297) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1789   +/-   ##
========================================
  Coverage    84.15%   84.15%           
========================================
  Files          753      753           
  Lines        26117    26117           
========================================
  Hits         21979    21979           
  Misses        4138     4138

Impacted Files	Coverage Δ
src/vt/termination/dijkstra-scholten/ds.cc	`90.72% <ø> (ø)`
src/vt/messaging/active.cc	`86.65% <100.00%> (ø)`

github-actions · 2022-05-09T20:37:48Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

github-actions · 2022-05-09T20:49:08Z

PR tests (clang-10, ubuntu, mpich)

Build for 32d858f

Compilation - successful

Testing - passed

Build log

lifflander added 2 commits May 9, 2022 12:24

#1788: TD: fix bug logical from node/destination

ebe2e3e

#1788: TD: improve debug prints

32d858f

lifflander requested review from PhilMiller, JacobDomagala, jstrzebonski, nlslatt, cz4rs and stmcgovern May 9, 2022 19:25

nlslatt approved these changes May 9, 2022

View reviewed changes

cz4rs approved these changes May 9, 2022

View reviewed changes

lifflander merged commit 5a23ba1 into develop May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1788 migrate collection test failure due to ds epochs #1789

1788 migrate collection test failure due to ds epochs #1789

lifflander commented May 9, 2022

nlslatt left a comment

lifflander commented May 9, 2022 •

edited

Loading

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

codecov bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

1788 migrate collection test failure due to ds epochs #1789

1788 migrate collection test failure due to ds epochs #1789

Conversation

lifflander commented May 9, 2022

nlslatt left a comment

Choose a reason for hiding this comment

lifflander commented May 9, 2022 • edited Loading

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

codecov bot commented May 9, 2022

Codecov Report

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

lifflander commented May 9, 2022 •

edited

Loading