1460 fix bug in temperedlb tolerance

[nlslatt]

As previously coded, TemperedLB would never skip LB due to low imbalance. Instead of changing the value, which is consistent with other LBs, I fixed the formula used for evaluating.

Fixes #1460

[lifflander]

Looks good

[github-actions]

PR tests (gcc-5, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-3.9, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-6, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-5.0, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[codecov]

Codecov Report

Merging #1794 (2fb725e) into develop (daa95fa) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 2fb725e differs from pull request most recent head 33c4120. Consider uploading reports for the commit 33c4120 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1794      +/-   ##
===========================================
- Coverage    84.18%   84.11%   -0.07%     
===========================================
  Files          755      753       -2     
  Lines        26246    26127     -119     
===========================================
- Hits         22096    21978     -118     
+ Misses        4150     4149       -1     

Impacted Files	Coverage Δ
...vt/vrt/collection/balance/temperedlb/temperedlb.cc	70.26% <100.00%> (-0.15%)	⬇️
src/vt/topos/location/location.impl.h	88.19% <0.00%> (-5.91%)	⬇️
src/vt/scheduler/priority_manip.cc	50.00% <0.00%> (-5.56%)	⬇️
src/vt/pipe/pipe_manager.cc	55.55% <0.00%> (-4.45%)	⬇️
src/vt/vrt/collection/balance/lb_common.cc	66.66% <0.00%> (-2.57%)	⬇️
src/vt/trace/trace_event.cc	75.00% <0.00%> (-1.20%)	⬇️
src/vt/vrt/collection/manager.impl.h	95.42% <0.00%> (-1.01%)	⬇️
src/vt/utils/compress/compressor.cc	83.33% <0.00%> (-0.88%)	⬇️
.../vt/vrt/collection/balance/lb_invoke/lb_manager.cc	76.52% <0.00%> (-0.79%)	⬇️
.../collection/balance/model/proposed_reassignment.cc	80.00% <0.00%> (-0.77%)	⬇️
... and 45 more

[github-actions]

PR tests (clang-9, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-10, alpine, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-11, ubuntu, mpich)

Build for 33c4120

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

[github-actions]

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (intel icpx, ubuntu, mpich)

Build for 33c4120

/vt/lib/EngFormat-Cpp/src/eng_format.cpp:144:15: warning: comparison with NaN always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    if      ( std::isnan( value ) ) return "NaN";
              ^~~~~~~~~~~~~~~~~~~
/vt/lib/EngFormat-Cpp/src/eng_format.cpp:145:15: warning: comparison with infinity always evaluates to false in fast floating point modes [-Wtautological-constant-compare]
    else if ( std::isinf( value ) ) return "INFINITE";
              ^~~~~~~~~~~~~~~~~~~
2 warnings generated.

Testing - passed

Build log

[github-actions]

PR tests (clang-13, ubuntu, mpich)

Build for 33c4120

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

[github-actions]

PR tests (clang-12, ubuntu, mpich)

Build for 33c4120

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

[github-actions]

PR tests (clang-14, ubuntu, mpich)

Build for 33c4120

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc:149:26: warning: 'mallinfo' is deprecated [-Wdeprecated-declarations]
    struct mallinfo mi = mallinfo();
                         ^
/usr/include/malloc.h:114:48: note: 'mallinfo' has been explicitly marked deprecated here
extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
                                               ^
/usr/include/malloc.h:32:30: note: expanded from macro '__MALLOC_DEPRECATED'
# define __MALLOC_DEPRECATED __attribute_deprecated__
                             ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:339:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^
1 warning generated.

Testing - passed

Build log

[github-actions]

PR tests (gcc-11, ubuntu, mpich)

Build for 33c4120

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59,
                 from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

[github-actions]

PR tests (gcc-12, ubuntu, mpich)

Build for 33c4120

In file included from src/CMakeFiles/vt.dir/Unity/unity_14_cxx.cxx:7:
/vt/src/vt/utils/memory/memory_usage.cc: In member function 'virtual std::size_t vt::util::memory::Mallinfo::getUsage()':
/vt/src/vt/utils/memory/memory_usage.cc:149:34: warning: 'mallinfo mallinfo()' is deprecated [-Wdeprecated-declarations]
  149 |     struct mallinfo mi = mallinfo();
      |                          ~~~~~~~~^~
In file included from /vt/src/vt/utils/memory/memory_usage.cc:59:
/usr/include/malloc.h:114:24: note: declared here
  114 | extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED;
      |                        ^~~~~~~~

Testing - passed

Build log

[github-actions]

PR tests (clang-10, ubuntu, mpich)

Build for 33c4120

Compilation - successful

Testing - passed

Build log