Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1820 Fix declaration hides member warnings #1821

Merged
merged 1 commit into from
May 20, 2022
Merged

1820 Fix declaration hides member warnings #1821

merged 1 commit into from
May 20, 2022

Conversation

nlslatt
Copy link
Collaborator

@nlslatt nlslatt commented May 20, 2022

Fixes #1820

@nlslatt nlslatt self-assigned this May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-11, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (intel icpx, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-10, alpine, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-13, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-12, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-11, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-14, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (gcc-12, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for 57d6738

Compilation - successful

Testing - passed

Build log

@nlslatt nlslatt force-pushed the 1820-fix-declaration-hides-member branch from cf67588 to 57d6738 Compare May 20, 2022 21:52
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1821 (57d6738) into develop (2dafa2f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1821      +/-   ##
===========================================
+ Coverage    84.12%   84.20%   +0.08%     
===========================================
  Files          752      752              
  Lines        26120    26120              
===========================================
+ Hits         21973    21994      +21     
+ Misses        4147     4126      -21
Impacted Files Coverage Δ
tests/unit/collection/test_lb_lite.extended.cc 91.48% <100.00%> (ø)
tests/unit/collection/test_mapping.cc 95.96% <100.00%> (ø)
src/vt/vrt/collection/manager.impl.h 96.42% <0.00%> (+2.71%) ⬆️
src/vt/vrt/collection/manager.h 100.00% <0.00%> (+33.33%) ⬆️

@PhilMiller PhilMiller merged commit d654077 into develop May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@cz4rs cz4rs Awaiting requested review from cz4rs

@nmm0 nmm0 Awaiting requested review from nmm0

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

Assignees

@nlslatt nlslatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix declaration hides member warnings
2 participants
@nlslatt @PhilMiller