Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1826: Remove all occurrences of '#pragma sst FOO' #1827

Merged
merged 1 commit into from
May 25, 2022

Conversation

PhilMiller
Copy link
Member

Automated with

git grep -l 'pragma sst' | xargs -n 1 sed -i '' -e '/pragma sst/d'

Fixes #1826

@PhilMiller PhilMiller requested review from nmm0 and nlslatt May 24, 2022 17:13
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-3.9, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-5, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-5.0, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-6, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-9, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-12, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-11, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (intel icpx, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-13, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-11, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-14, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (gcc-12, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (clang-10, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented May 24, 2022

PR tests (intel icpc, ubuntu, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@nlslatt nlslatt force-pushed the 1826-strip-sst-pragmas branch 2 times, most recently from 57d8f2d to 5b3cd60 Compare May 24, 2022 22:32
@github-actions
Copy link

PR tests (alpine, clang-13, mpich)

Build for 5b3cd60

Compilation - successful

Testing - passed

Build log

@nlslatt nlslatt force-pushed the 1826-strip-sst-pragmas branch from 5b3cd60 to 11e6d28 Compare May 25, 2022 16:32
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1827 (11e6d28) into develop (152c895) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1827      +/-   ##
===========================================
+ Coverage    84.11%   84.14%   +0.02%     
===========================================
  Files          752      752              
  Lines        26120    26120              
===========================================
+ Hits         21971    21978       +7     
+ Misses        4149     4142       -7     
Impacted Files Coverage Δ
src/vt/collective/collective_ops.cc 89.83% <ø> (ø)
src/vt/collective/tree/tree.h 100.00% <ø> (ø)
src/vt/objgroup/type_registry/registry.impl.h 100.00% <ø> (ø)
src/vt/registry/auto/auto_registry_general.h 100.00% <ø> (ø)
src/vt/sequence/seq_matcher.impl.h 97.67% <ø> (ø)
src/vt/sequence/seq_matcher_virtual.impl.h 48.83% <ø> (ø)
src/vt/sequence/sequencer_virtual.impl.h 80.55% <ø> (ø)
src/vt/vrt/collection/dispatch/registry.impl.h 93.75% <ø> (ø)
src/vt/vrt/collection/manager.impl.h 96.42% <ø> (+1.00%) ⬆️

@github-actions
Copy link

PR tests (clang-13, alpine, mpich)

Build for 11e6d28

Compilation - successful

Testing - passed

Build log

@nlslatt nlslatt merged commit 5023946 into develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strip #pragma sst
3 participants