Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1967: TD: add enable/disable for performance tests #1968

Merged

Conversation

lifflander
Copy link
Collaborator

Fixes #1967

@github-actions
Copy link

github-actions bot commented Sep 19, 2022

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-5, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for c537410

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for c537410

Compilation - successful

Testing - passed

Build log


@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1968 (c537410) into develop (31988ae) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1968      +/-   ##
===========================================
+ Coverage    84.07%   84.11%   +0.03%     
===========================================
  Files          728      728              
  Lines        25594    25604      +10     
===========================================
+ Hits         21518    21536      +18     
+ Misses        4076     4068       -8     
Impacted Files Coverage Δ
src/vt/termination/termination.cc 71.20% <0.00%> (-1.44%) ⬇️
src/vt/termination/termination.h 100.00% <ø> (ø)
src/vt/phase/phase_manager.cc 92.56% <0.00%> (+1.35%) ⬆️
src/vt/topos/location/location.impl.h 94.09% <0.00%> (+5.90%) ⬆️

Copy link
Member

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd phrase the warnings and assertions in the affirmative, as only working for wave based epochs.

Other than that, looks good

@lifflander lifflander merged commit dac116e into develop Sep 20, 2022
cz4rs pushed a commit that referenced this pull request Sep 28, 2022
…able-td-for-performance-testing

#1967: TD: add enable/disable for performance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add interface to disable TD for performance testing
3 participants