Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1969: scheduler: reduce calls to get the current time #1971

Merged
merged 1 commit into from
Sep 28, 2022
Merged

#1969: scheduler: reduce calls to get the current time #1971

merged 1 commit into from
Sep 28, 2022
+60 −12

Conversation

lifflander
Copy link
Collaborator

Fixes #1969

@lifflander lifflander linked an issue Sep 20, 2022 that may be closed by this pull request
Try to reduce more MPI_Wtime calls when scheduler/progress features are disabled #1969
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Sep 20, 2022 •
edited
Loading

Pipelines results

PR tests (clang-5.0, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-3.9, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 090d9cb

Compilation - successful

Testing - passed

Build log

@lifflander lifflander force-pushed the 1969-try-to-reduce-more-mpi_wtime-calls-when-schedulerprogress-features-are-disabled branch from fd87c43 to bb0d735 Compare September 27, 2022 20:51
@lifflander
#1969: scheduler: reduce calls to get the current time

Unverified

No user is associated with the committer email.
Learn about vigilant mode
090d9cb
@lifflander lifflander force-pushed the 1969-try-to-reduce-more-mpi_wtime-calls-when-schedulerprogress-features-are-disabled branch from bb0d735 to 090d9cb Compare September 27, 2022 20:52
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1971 (090d9cb) into develop (ad1c783) will decrease coverage by 0.05%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1971      +/-   ##
===========================================
- Coverage    84.37%   84.32%   -0.06%     
===========================================
  Files          727      728       +1     
  Lines        25491    25508      +17     
===========================================
  Hits         21509    21509              
- Misses        3982     3999      +17
Impacted Files Coverage Δ
src/vt/runtime/component/component_pack.h 100.00% <ø> (ø)
src/vt/scheduler/scheduler.h 100.00% <ø> (ø)
src/vt/timetrigger/time_trigger_manager.h 100.00% <ø> (ø)
src/vt/scheduler/scheduler.cc 68.71% <56.25%> (-7.92%) ⬇️
src/vt/runtime/component/component_pack.cc 97.05% <100.00%> (+0.18%) ⬆️
src/vt/runtime/component/progressable.h 100.00% <100.00%> (ø)
src/vt/runtime/runtime.h 100.00% <100.00%> (ø)
src/vt/timetrigger/time_trigger_manager.cc 95.45% <100.00%> (+0.45%) ⬆️
src/vt/phase/phase_manager.cc 89.86% <0.00%> (-1.36%) ⬇️

@lifflander lifflander merged commit 741065e into develop Sep 28, 2022
cz4rs pushed a commit that referenced this pull request Sep 28, 2022
@lifflander @cz4rs
Merge pull request #1971 from DARMA-tasking/1969-try-to-reduce-more-m…

Unverified

No user is associated with the committer email.
Learn about vigilant mode
6682a59 
…pi_wtime-calls-when-schedulerprogress-features-are-disabled

#1969: scheduler: reduce calls to get the current time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcgovern stmcgovern

@PhilMiller PhilMiller

@cz4rs cz4rs

@nmm0 nmm0

@thearusable thearusable

@JacobDomagala JacobDomagala

@jstrzebonski jstrzebonski

@nlslatt nlslatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to reduce more MPI_Wtime calls when scheduler/progress features are disabled
2 participants
@lifflander @stmcgovern