Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2007: Skip TestLBDataRetention tests when num_ranks > num_elems #2012

Merged
merged 1 commit into from
Nov 9, 2022
Merged

2007: Skip TestLBDataRetention tests when num_ranks > num_elems #2012

merged 1 commit into from
Nov 9, 2022

Conversation

JacobDomagala
Copy link
Contributor

Fixes #2007

@github-actions
Copy link

github-actions bot commented Nov 9, 2022 •
edited
Loading

Pipelines results

PR tests (clang-3.9, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 9a24f4b (2022-11-09 14:28:45 UTC)

Compilation - successful

Testing - passed

Build log

cz4rs
cz4rs approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

cz4rs
cz4rs reviewed Nov 9, 2022
View reviewed changes
tests/unit/collection/test_lb_data_retention.cc
@@ -105,20 +106,24 @@ struct TestCol : vt::Collection<TestCol,vt::Index1D> {
}
};

using TestLBDataRetention = TestParallelHarness;
static constexpr int32_t const num_elms = 16;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could raise this to 32 anyways (while keeping SET_MAX_NUM_NODES_CONSTRAINT), it doesn't seem to take much time.

nlslatt
nlslatt approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nlslatt nlslatt merged commit 6160443 into develop Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@nlslatt nlslatt nlslatt approved these changes

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@lifflander lifflander Awaiting requested review from lifflander

@nmm0 nmm0 Awaiting requested review from nmm0

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@thearusable thearusable Awaiting requested review from thearusable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail when run on more ranks than there are elements
3 participants
@JacobDomagala @cz4rs @nlslatt