Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2018: Remove support for old compilers #2021

Merged
merged 2 commits into from
Dec 7, 2022
Merged

#2018: Remove support for old compilers #2021

merged 2 commits into from
Dec 7, 2022

Conversation

thearusable
Copy link
Contributor

Closes #2018

@thearusable thearusable self-assigned this Nov 23, 2022
@github-actions
Copy link

github-actions bot commented Nov 23, 2022 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 3c5f095 (2022-11-25 14:24:55 UTC)

Compilation - successful

Testing - passed

Build log

@thearusable thearusable marked this pull request as ready for review November 28, 2022 10:15
@thearusable thearusable force-pushed the 2018-remove-support-for-old-compilers branch from 3c5f095 to 9ace873 Compare November 28, 2022 10:18
@thearusable thearusable requested a review from cz4rs November 28, 2022 10:19
@cz4rs cz4rs mentioned this pull request Nov 28, 2022
Merged
@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited
Loading

Codecov Report

Merging #2021 (17dc010) into develop (da71bac) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2021      +/-   ##
===========================================
- Coverage    84.48%   84.44%   -0.04%     
===========================================
  Files          731      731              
  Lines        25847    25847              
===========================================
- Hits         21836    21827       -9     
- Misses        4011     4020       +9
Impacted Files Coverage Δ
src/vt/phase/phase_manager.cc 89.86% <0.00%> (-1.36%) ⬇️
src/vt/vrt/collection/manager.impl.h 95.48% <0.00%> (-0.99%) ⬇️

cz4rs
cz4rs approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@thearusable thearusable force-pushed the 2018-remove-support-for-old-compilers branch from 9ace873 to 3ea15bc Compare November 29, 2022 13:00
@thearusable thearusable force-pushed the 2018-remove-support-for-old-compilers branch 2 times, most recently from 1603075 to c79593e Compare December 6, 2022 17:32
@thearusable thearusable force-pushed the 2018-remove-support-for-old-compilers branch from c79593e to 17dc010 Compare December 6, 2022 18:27
@lifflander lifflander merged commit b04218c into develop Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt approved these changes

@cz4rs cz4rs cz4rs approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for gcc-5, gcc-6, clang-3.9
5 participants
@thearusable @PhilMiller @cz4rs @nlslatt @lifflander