Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2260: Enable one verbose build for each compiler type #2263

Merged
merged 13 commits into from
Apr 22, 2024

Conversation

thearusable
Copy link
Contributor

@thearusable thearusable commented Mar 27, 2024

Closes #2260

@thearusable thearusable self-assigned this Mar 27, 2024
@thearusable thearusable force-pushed the 2260-add-debug-prints-on-ci branch from 6112f3b to f4c891d Compare March 27, 2024 15:34
Copy link

github-actions bot commented Mar 27, 2024

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 0165e84 (2024-03-28 11:36:03 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich, verbose)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage, verbose)

Build for 0165e84 (2024-03-28 11:36:03 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 554d368 (2024-04-22 13:47:43 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log


PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 554d368 (2024-04-22 13:47:43 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(202): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich, verbose)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 554d368 (2024-04-22 13:47:43 UTC)

Compilation - successful

Testing - passed

Build log


@thearusable thearusable force-pushed the 2260-add-debug-prints-on-ci branch from f4c891d to 22c5b12 Compare March 28, 2024 09:51
@thearusable thearusable marked this pull request as ready for review March 28, 2024 11:36
@thearusable thearusable force-pushed the 2260-add-debug-prints-on-ci branch from 22c5b12 to 0165e84 Compare March 28, 2024 11:36
@JacobDomagala
Copy link
Contributor

Should we use PR tests (gcc-12, ubuntu, mpich) for verbose? It's the PR that runs even in draft mode.

@thearusable
Copy link
Contributor Author

Should we use PR tests (gcc-12, ubuntu, mpich) for verbose? It's the PR that runs even in draft mode.

@JacobDomagala Yes, I think that's a great idea. I'll make this gcc pipeline a verbose one.

@thearusable thearusable force-pushed the 2260-add-debug-prints-on-ci branch 3 times, most recently from 47fde7f to b7bc7a2 Compare April 16, 2024 15:51
@thearusable
Copy link
Contributor Author

Debug verbose logs are enabled for:

  • clang-14
  • gcc-12
  • icpx
  • nvcc-12

Verbose debug logs are being compiled for jobs on those compilers but they won't be printed on CI. Enabling verbose logging for all modules with --vt_debug_all will result in very verbose output which is hard to analyze.

@thearusable thearusable marked this pull request as draft April 17, 2024 11:13
@thearusable thearusable force-pushed the 2260-add-debug-prints-on-ci branch 2 times, most recently from 5811e08 to 3615b30 Compare April 17, 2024 13:41
@thearusable thearusable marked this pull request as ready for review April 17, 2024 13:41
@thearusable
Copy link
Contributor Author

@lifflander / @nlslatt - I poked a little bit to check why you have the issue with missing verbose logs.

I only found that not all of the parameters are being passed when building docker images. But that's all I found. All configuration in CMake looks good to me. Every option is properly stored in CMake's cache and it's properly overridden when we pass a different value for a flag.

@@ -48,11 +48,12 @@ variables:
VT_PRODUCTION_BUILD: 0
VT_FCONTEXT: 0
VT_ZOLTAN: 0
VT_CI_BUILD: 1
VT_CI_BUILD: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like lying about whether this is a CI build, since that option may be used in the future for other things. Is there a different approach we can take to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lifflander - Yes, I made a small change to ignore VT_CI_BUILD when we use parameter for verbose logging.
https://github.com/DARMA-tasking/vt/pull/2263/files#diff-e26a8025f4a8b2bfdebc788c5331bfdfdfc7a57c583a798c6a7dfe32cbc06921R68

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz

Verified

This commit was signed with the committer’s verified signature.
thearusable Arkadiusz Szczepkowicz
@thearusable thearusable force-pushed the 2260-add-debug-prints-on-ci branch from 7682516 to 554d368 Compare April 22, 2024 13:47
@lifflander lifflander merged commit ae7478d into develop Apr 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One CI build should compile with verbose debug prints to check that they compile (at the least)
3 participants