-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2260: Enable one verbose build for each compiler type #2263
Conversation
6112f3b
to
f4c891d
Compare
Pipelines resultsPR tests (gcc-12, ubuntu, mpich) Build for 0165e84 (2024-03-28 11:36:03 UTC)
PR tests (clang-9, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (clang-13, alpine, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (clang-11, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (clang-10, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (clang-12, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (intel icpx, ubuntu, mpich, verbose) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (gcc-10, ubuntu, openmpi, no LB) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (clang-13, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (clang-14, ubuntu, mpich, verbose) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage, verbose) Build for 0165e84 (2024-03-28 11:36:03 UTC)
PR tests (intel icpc, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (gcc-12, ubuntu, mpich, verbose) Build for 554d368 (2024-04-22 13:47:43 UTC)
PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage) Build for 554d368 (2024-04-22 13:47:43 UTC)
|
f4c891d
to
22c5b12
Compare
22c5b12
to
0165e84
Compare
Should we use |
@JacobDomagala Yes, I think that's a great idea. I'll make this gcc pipeline a verbose one. |
47fde7f
to
b7bc7a2
Compare
Debug verbose logs are enabled for:
Verbose debug logs are being compiled for jobs on those compilers but they won't be printed on CI. Enabling verbose logging for all modules with |
5811e08
to
3615b30
Compare
@lifflander / @nlslatt - I poked a little bit to check why you have the issue with missing verbose logs. I only found that not all of the parameters are being passed when building docker images. But that's all I found. All configuration in CMake looks good to me. Every option is properly stored in CMake's cache and it's properly overridden when we pass a different value for a flag. |
@@ -48,11 +48,12 @@ variables: | |||
VT_PRODUCTION_BUILD: 0 | |||
VT_FCONTEXT: 0 | |||
VT_ZOLTAN: 0 | |||
VT_CI_BUILD: 1 | |||
VT_CI_BUILD: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like lying about whether this is a CI build, since that option may be used in the future for other things. Is there a different approach we can take to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifflander - Yes, I made a small change to ignore VT_CI_BUILD
when we use parameter for verbose logging.
https://github.com/DARMA-tasking/vt/pull/2263/files#diff-e26a8025f4a8b2bfdebc788c5331bfdfdfc7a57c583a798c6a7dfe32cbc06921R68
7682516
to
554d368
Compare
Closes #2260