480 serialization reduce vec msg #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifflander
approved these changes
Oct 7, 2019
The operator is now compatible with vector of bool
The test is only for vector of bool. The vector of int test is coming.
lifflander
force-pushed
the
480-serialization-ReduceVecMsg
branch
from
97c00ed to
f9cb5e3
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReduceVectorMsg is now serializable.
A test has been added for vector of bool and vector of int.
The specialization
struct PlusOp< std::vector<bool> >has been added because the general operationv1[ii] += v2[ii];doesn't work for std::vector of bool whenv1[ii] = v1[ii] + v2[ii];works.I think we can also change the operation from
v1[ii] += v2[ii];tov1[ii] = v1[ii] + v2[ii];in the general PlusOp template but it's probably less optimized.