517 remove extraneous commas #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlslatt
requested review from
PhilMiller,
pnstickne,
lifflander and
uhetmaniuk
|
Jonathan just added those in #513 |
|
Thanks, @pbmille. My search attempts missed that one. |
|
Actually, @pbmille, #513 is what caused my compile errors. The macro in question is defined as in the versions of gtest used by EMPIRE and vt-auto-build. |
lifflander
changed the title
|
@nlslatt I think we should merge this and start using the same version of gtest that EMPIRE uses for VT (if we care about the warnings). It's just a warning on VT's version of gtest, so I think we are fine. In the latest releases of gtest, this macro completely changes form (and has a updated name) so we eventually won't have this problem. |
lifflander
approved these changes
Oct 26, 2019
lifflander
changed the title
lifflander
force-pushed
the
517-extraneous-commas
branch
from
052f6f9 to
4d64b95
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #517. Removed the trailing comma in the argument list for
INSTANTIATE_TYPED_TEST_CASE_P, which only takes 3 arguments.