538 remove tuple from debug::useVars #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this an improvement, but we need to test this more extensively on ICC and CUDA to see if passes. Thus, I'm not marking this for |
PhilMiller
reviewed
Nov 4, 2019
nlslatt
reviewed
Nov 6, 2019
|
@PhilMiller @nlslatt Can I get approval to merge this? I tagged it for 1.0.0-beta.4 since it's working with icc. |
|
This appears to build with cuda as well. |
nlslatt
approved these changes
Nov 12, 2019
- What's faster than instantiating a tuple? Not instantiating a tuple. Tuple instantiation is SLLLLLOW in comparison, especially over many more types. Compilers may (or may not) optimize out entire construct.
lifflander
force-pushed
the
538-remove-use-vars-tuple
branch
from
c9e2ffd to
e1e0778
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's faster than instantiating a tuple?
Not instantiating a tuple.
Tuple instantiation is SLLLLLOW in comparison,
especially over many more types.
Compilers may (or may not) optimize out entire construct.
Fixes #583