539 perf. colorization code and unify color selection #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
approved these changes
Nov 4, 2019
- Rules for configuration are defined (AND followed..); logic happens immediately after parsing which ensures only one isatty check (ioctl) and centralized logic handling. Updated the setting/diagnostic messages to also align with the rules. Rules: - no-color DISABLES color - color ENABLES color - auto-color (assumed default) enables color in terminal (This makes VT consistent with tools like 'ls', or more so..) - Removes unistd.h bleed - should be removed from other headers - Consistently use defined colors and other minor formatting; swith to 'standard' functions.
lifflander
force-pushed
the
539-colorize-efficiency
branch
from
c8a1670 to
deeefde
Compare
This was referenced Nov 5, 2019
pnstickne
added a commit
that referenced
this pull request
Nov 22, 2019
- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..
lifflander
pushed a commit
that referenced
this pull request
Nov 27, 2019
- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..
lifflander
pushed a commit
that referenced
this pull request
Nov 30, 2019
- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..
lifflander
pushed a commit
that referenced
this pull request
Dec 10, 2019
- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..
pnstickne
added a commit
that referenced
this pull request
Dec 13, 2019
- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..
lifflander
pushed a commit
that referenced
this pull request
Jan 7, 2020
- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules for configuration are defined (AND followed..);
logic happens immediately after parsing which ensures
only one isatty check (ioctl) and centralized logic handling.
Updated the setting/diagnostic messages to also align
with the rules.
Rules:
(This makes VT consistent with tools like 'ls', or more so..)
Removes unistd.h bleed - should be removed from other headers
Consistently use defined colors and other minor formatting;
swith to 'standard' functions.