#592 vtAbort if LB compile-time disabled but runtime enabled #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifflander
requested review from
PhilMiller,
pnstickne,
nlslatt and
uhetmaniuk
PhilMiller
approved these changes
Nov 26, 2019
PhilMiller
reviewed
Nov 26, 2019
| // actually executes | ||
| theSched->enqueue([this]{ | ||
| this->checkForArgumentErrors(); | ||
| }); |
There was a problem hiding this comment.
Isn't this a bit racy? How do you ensure this is after whatever last point that arguments could safely be modified?
The principled solution to that issue would distinguish the name and type of "structure containing arguments as they are being processed" from "structure containing arguments as they should be used to initialize and execute", with the latter of course being immutable.
There was a problem hiding this comment.
@pbmille You want beta.4 merged soon, right?
There was a problem hiding this comment.
Yes, this only works if EMPIRE doesn't call into the scheduler before modifying the args. We are looking for a solution where EMPIRE doesn't have to change.
nlslatt
approved these changes
Nov 26, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592