642 simplify trace pairs #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnstickne
commented
Dec 21, 2019
| trace::TraceEventIDType event = envelopeGetTraceEvent(msg->env); | ||
|
|
||
| fmt::print("dataMessageHandler: id={}, ep={}\n", msg->sub_han, ep); | ||
| trace::TraceProcessingTag processing_tag; |
There was a problem hiding this comment.
Each begin only requires the processing tag to close.
Once/if the open event stack is removed it can be used to support asynchronous paired events..
pnstickne
commented
Dec 21, 2019
| #if backend_check_enabled(trace_enabled) | ||
| #if backend_check_enabled(trace_enabled) | ||
| trace::TraceProcessingTag processing_tag; | ||
| { |
There was a problem hiding this comment.
{..} to uniformly reduce variable scopes, as such as are no longer used/required.
pnstickne
commented
Dec 21, 2019
src/vt/trace/trace.cc
Outdated
| ); | ||
| // This is current contract expectations; however it precludes async closing. | ||
| vtAssert( | ||
| open_events_.top().ep == ep and |
There was a problem hiding this comment.
End goal might be to remove the open event stack and re-compose on the target side only.
pnstickne
commented
Dec 21, 2019
|
|
||
| // Already added to traces |
Codecov Report
@@ Coverage Diff @@
## develop #642 +/- ##
========================================
Coverage 83.25% 83.25%
========================================
Files 310 310
Lines 10398 10398
========================================
Hits 8657 8657
Misses 1741 1741
|
pnstickne
commented
Jan 15, 2020
| @@ -91,13 +111,24 @@ struct Trace { | |||
| std::string const& in_dir_name = "" | |||
| ); | |||
|
|
|||
| void beginProcessing( | |||
| /// Initiate a paired event. | |||
There was a problem hiding this comment.
Check Doxygen format used for VT.
pnstickne
commented
Jan 15, 2020
| /// Finalize a paired event. | ||
| /// The processing_tag value comes from beginProcessing. | ||
| void endProcessing( | ||
| TraceProcessingTag processing_tag, |
lifflander
force-pushed
the
642-simplify-trace-pairs
branch
from
b7483bf to
f75ec43
Compare
pnstickne
pushed a commit
that referenced
this pull request
Feb 1, 2020
- No need (or desired ability) to supply all stuff AGAIN on and end processing.. and end processing tag must always mirror that of a start processing tag currently. If there was DIFFERENT information to include, other than a timestamp, that can be re-explored.
pnstickne
added a commit
that referenced
this pull request
Feb 1, 2020
- As all core usages pass in exactly the same values, as expected 'everywhere', the usages have been updated to work with the single processing tag.
pnstickne
force-pushed
the
642-simplify-trace-pairs
branch
from
f75ec43 to
cc23003
Compare
|
@lifflander Bump. All clean. All rebased. |
- No need (or desired ability) to supply all stuff AGAIN on and end processing.. and end processing tag must always mirror that of a start processing tag currently. If there was DIFFERENT information to include, other than a timestamp, that can be re-explored.
- As all core usages pass in exactly the same values, as expected 'everywhere', the usages have been updated to work with the single processing tag.
lifflander
force-pushed
the
642-simplify-trace-pairs
branch
from
cc23003 to
e06e58a
Compare
lifflander
approved these changes
Feb 5, 2020
pnstickne
added a commit
that referenced
this pull request
Feb 8, 2020
- Was incorrectly guarding 'event type' == 0, which CAN be true.. ..even if it probably should be the case. Now guards against the 'entry id' itself.
lifflander
pushed a commit
that referenced
this pull request
Feb 9, 2020
- Was incorrectly guarding 'event type' == 0, which CAN be true.. ..even if it probably should be the case. Now guards against the 'entry id' itself.
lifflander
added a commit
that referenced
this pull request
Feb 13, 2020
- No need (or desired ability) to supply all stuff AGAIN on and end processing.. and end processing tag must always mirror that of a start processing tag currently. If there was DIFFERENT information to include, other than a timestamp, that can be re-explored.
lifflander
pushed a commit
that referenced
this pull request
Feb 13, 2020
- As all core usages pass in exactly the same values, as expected 'everywhere', the usages have been updated to work with the single processing tag.
lifflander
pushed a commit
that referenced
this pull request
Feb 13, 2020
- Was incorrectly guarding 'event type' == 0, which CAN be true.. ..even if it probably should be the case. Now guards against the 'entry id' itself.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.