Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#659: Eliminate unused (member/capture) variables that Clang 7 warns about #661

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

PhilMiller
Copy link
Member

No description provided.

@PhilMiller PhilMiller requested a review from lifflander February 3, 2020 19:36
@PhilMiller
Copy link
Member Author

Note I've got separate pull requests up for beta.5 and develop

@lifflander lifflander self-assigned this Feb 3, 2020
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lifflander lifflander force-pushed the 659-develop-clang-warnings branch from c1a59c7 to b9c08a4 Compare February 3, 2020 20:30
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #661 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #661   +/-   ##
========================================
  Coverage    83.25%   83.25%           
========================================
  Files          310      310           
  Lines        10398    10398           
========================================
  Hits          8657     8657           
  Misses        1741     1741

@lifflander lifflander merged commit 7de3acb into develop Feb 3, 2020
@PhilMiller PhilMiller mentioned this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants