723 Add debugging epoch labels #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifflander
requested review from
PhilMiller,
pnstickne,
nmm0,
nlslatt and
uhetmaniuk
Codecov Report
@@ Coverage Diff @@
## develop #724 +/- ##
===========================================
+ Coverage 79.06% 79.08% +0.01%
===========================================
Files 333 334 +1
Lines 10162 10174 +12
===========================================
+ Hits 8035 8046 +11
- Misses 2127 2128 +1
|
lifflander
force-pushed
the
723-epoch-labels
branch
2 times, most recently
from
141ad1e to
1f3d8bb
Compare
PhilMiller
reviewed
Mar 6, 2020
PhilMiller
reviewed
Mar 6, 2020
PhilMiller
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
|
|
||
| SuccessorEpochCapture::SuccessorEpochCapture() | ||
| : epoch_( | ||
| (theMsg()->getEpoch() != no_epoch and |
There was a problem hiding this comment.
Consider TU-local/file method accepting theMsg()->getEpoch() -> maybe_epoch.
There was a problem hiding this comment.
Not sure what this means.
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
pnstickne
reviewed
Mar 6, 2020
Add a new optional parameter when creating a new epoch to specify a label that is dumped in debugging output (DOT files). In order to make this change correctly, a breaking change is made on non-default overloads of TermminationDetector::makeEpochCollective and TermminationDetector::makeEpochRooted due to char* to bool overload problems. Thus, a tag class is used to specify if the epoch should use the current epoch as the succesor or whether a DS epoch should be used. This has the added benefit of making the interface more explicit and less error prone.
lifflander
force-pushed
the
723-epoch-labels
branch
from
0c3209a to
5670ef2
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723
Add a new optional parameter when creating a new epoch to specify a label that is dumped in debugging output (DOT files). In order to make this change correctly, a breaking change is made on non-default overloads of
TerminationDetector::makeEpochCollectiveandTerminationDetector::makeEpochRooteddue to char* to bool overload problems.Thus, a tag class is used to specify/capture if the successor epoch should be the current epoch (or an manual override by the user) or whether a DS epoch should be used. This has the added benefit of making the interface more explicit and less error prone.
outfile-global.pdf
This has potential for beta.6, depending on feedback.