#647 fix format-string type warnings #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #747 +/- ##
========================================
Coverage 79.05% 79.05%
========================================
Files 337 337
Lines 10247 10247
========================================
Hits 8101 8101
Misses 2146 2146 |
pnstickne
changed the title
pnstickne
commented
Mar 27, 2020
| @@ -144,8 +144,8 @@ void StatsRestartReader::inputStatsFile( | |||
| fpos_t pos; | |||
| bool finished = false; | |||
| while (!finished) { | |||
| if (fscanf(pFile, "%zu %c %llu %c %lf", &phaseID, &separator, &elmID, | |||
| &separator, &tval) > 0) { | |||
| if (fscanf(pFile, "%zu %c %lu %c %lf", | |||
There was a problem hiding this comment.
Or change ElementIDType to be large enough for llu.
There was a problem hiding this comment.
Actually, in this case it might be better to capture to a unsigned long local and convert before use to minimize changes..
lifflander
approved these changes
Apr 8, 2020
lifflander
force-pushed
the
647-fix-compiler-warnings
branch
from
958de21 to
2a80eab
Compare
- Ensure types are fully compatible with the format specifier. Some compilers check and generate warnings.
lifflander
force-pushed
the
647-fix-compiler-warnings
branch
from
2a80eab to
586d583
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers check and generate warnings.
No warnings in GCC7/Clang5/ICC18 for VT or example builds.