769 gossip bugs #770
Merged
769 gossip bugs #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #770 +/- ##
========================================
Coverage 79.30% 79.30%
========================================
Files 338 338
Lines 10410 10410
========================================
Hits 8256 8256
Misses 2154 2154 |
PhilMiller
approved these changes
Apr 17, 2020
lifflander
force-pushed
the
769-gossip-bugs
branch
from
b34d451 to
d5a821c
Compare
pnstickne
reviewed
Apr 18, 2020
| auto msg = makeMessage<ReduceMsgType>(); | ||
| proxy_.reduce(msg.get(), cb); | ||
|
|
||
| while (not setup_done_) { |
There was a problem hiding this comment.
There is a cute little construct for this in some branch :'(
lifflander
force-pushed
the
769-gossip-bugs
branch
from
d5a821c to
eafc39b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769