774 irecv test right away #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks good to me. @nlslatt did you see any impact on performance before and after this change? |
Codecov Report
@@ Coverage Diff @@
## develop #775 +/- ##
========================================
Coverage 79.30% 79.30%
========================================
Files 338 338
Lines 10410 10410
========================================
Hits 8256 8256
Misses 2154 2154 |
lifflander
force-pushed
the
774-irecv-test-right-away
branch
from
a3e938f to
c96b743
Compare
lifflander
force-pushed
the
774-irecv-test-right-away
branch
from
c96b743 to
b5aadbf
Compare
I didn't analyze the performance impact of this change because the code was not running correctly at the time. Would you like me to check it now? |
Also, I had only implemented the immediate test on data msgs, not active msgs. |
nlslatt
approved these changes
Apr 18, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #774