Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

884 rename getNumTotalChildren to getNumDescendants #980

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Aug 11, 2020

rename the method and update the docs

Fixes #884

@cz4rs cz4rs force-pushed the 884-rename-getNumTotalChildren branch from 57f60cd to 90ebfb1 Compare August 11, 2020 15:13
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #980 into develop will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #980   +/-   ##
========================================
  Coverage    77.35%   77.35%           
========================================
  Files          656      656           
  Lines        25104    25104           
========================================
  Hits         19418    19418           
  Misses        5686     5686           
Impacted Files Coverage Δ
src/vt/collective/tree/tree.h 100.00% <ø> (ø)
src/vt/collective/tree/tree.cc 82.43% <75.00%> (ø)
src/vt/collective/scatter/scatter.cc 100.00% <100.00%> (ø)

@cz4rs cz4rs force-pushed the 884-rename-getNumTotalChildren branch from 90ebfb1 to 78fffb3 Compare August 11, 2020 16:07
@cz4rs cz4rs requested review from lifflander and PhilMiller August 11, 2020 16:33
@cz4rs cz4rs changed the title #884 rename getNumTotalChildren to getNumDescendants 884 rename getNumTotalChildren to getNumDescendants Aug 12, 2020
@cz4rs cz4rs requested a review from pnstickne August 13, 2020 19:57
@cz4rs cz4rs force-pushed the 884-rename-getNumTotalChildren branch from 448e6ff to 102f807 Compare August 14, 2020 12:06
@cz4rs cz4rs force-pushed the 884-rename-getNumTotalChildren branch from 102f807 to 4f67834 Compare August 17, 2020 12:37
@cz4rs
Copy link
Contributor Author

cz4rs commented Aug 17, 2020

rebased on top of develop, ready for merging

@PhilMiller PhilMiller merged commit 3dfddb2 into develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In collective/tree/tree.h Rename Tree::getNumTotalChildren to Tree::getNumDescendants
4 participants