939 de-template BaseElmProxy over ColT #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #983 +/- ##
========================================
Coverage 77.35% 77.35%
========================================
Files 656 656
Lines 25104 25104
========================================
Hits 19418 19418
Misses 5686 5686
|
pnstickne
reviewed
Aug 14, 2020
| @@ -58,7 +58,7 @@ namespace vt { namespace vrt { namespace collection { | |||
| template <typename ColT, typename IndexT> | |||
| CollectionUntypedProxy::ElmProxyType<ColT, IndexT> | |||
| CollectionUntypedProxy::index(IndexT const& idx) const { | |||
| return ElmProxyType<ColT, IndexT>{proxy_,BaseElmProxy<ColT,IndexT>{idx}}; | |||
There was a problem hiding this comment.
Can ColT also be removed from ElmProxyType?
There was a problem hiding this comment.
Quite possibly, but let's integrate this in small steps, so that we don't generate merge conflicts all over the place with a long-lived, sprawling PR
There was a problem hiding this comment.
Please check into the specific possibility (i.e. looking for uses of the template parameter) and open an issue if you believe it to be feasible.
pnstickne
approved these changes
Aug 14, 2020
PhilMiller
approved these changes
Aug 14, 2020
lifflander
approved these changes
Aug 15, 2020
|
@cz4rs I think this is ready to merge after you rebase! |
lifflander
force-pushed
the
939-de-template-base-elm-proxy
branch
from
159fadb to
3a12cb8
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939