955 clear out uses of addAction from tests #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz4rs
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #989 +/- ##
===========================================
+ Coverage 77.40% 77.41% +0.01%
===========================================
Files 656 656
Lines 25137 25151 +14
===========================================
+ Hits 19457 19471 +14
Misses 5680 5680
|
cz4rs
requested review from
lifflander,
bradybray,
JacobDomagala,
PhilMiller and
pnstickne
cz4rs
force-pushed
the
955-clear-out-uses-of-addAction-in-tests-part4
branch
from
82d50b7 to
8f0fd7b
Compare
JacobDomagala
approved these changes
Aug 18, 2020
PhilMiller
requested changes
Aug 18, 2020
11 tasks
PhilMiller
approved these changes
Aug 18, 2020
cz4rs
force-pushed
the
955-clear-out-uses-of-addAction-in-tests-part4
branch
from
efe6ed5 to
2d67222
Compare
|
rebased on top of develop @lifflander @PhilMiller |
cz4rs
force-pushed
the
955-clear-out-uses-of-addAction-in-tests-part4
branch
2 times, most recently
from
f120493 to
7683d35
Compare
|
The code looks good to me now. @lifflander could you double-check the location manager test change? |
lifflander
force-pushed
the
955-clear-out-uses-of-addAction-in-tests-part4
branch
from
7683d35 to
42c49cf
Compare
lifflander
approved these changes
Aug 25, 2020
|
Clones added
============
- tests/unit/pipe/test_callback_bcast_collection.extended.cc 5
See the complete overview on Codacy |
|
Looks good to me, let's get it merged |
bradybray
deleted the
955-clear-out-uses-of-addAction-in-tests-part4
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove remaining usage of addAction from:
tests/unit/pipe/test_callback_bcast_collection.extended.cctests/unit/location/test_location_common.h