Visible offline 2.0 #129
Merged
Visible offline 2.0 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattcarter11
commented
Dec 11, 2024
mattcarter11
commented
- centralize SongListItem logic
- select header also consider connection
mattcarter11
force-pushed
the
visible-offline
branch
3 times, most recently
from
cc883b8 to
3ad3895
Compare
mikooomich
reviewed
Jan 1, 2025
app/src/main/java/com/dd3boh/outertune/ui/screens/HistoryScreen.kt
Outdated
Show resolved
Hide resolved
mattcarter11
force-pushed
the
visible-offline
branch
from
e2fc9d5 to
5626fbe
Compare
mattcarter11
force-pushed
the
visible-offline
branch
from
267e1eb to
5b3f17d
Compare
|
History screen multi select doesn't work for disable songs, but it does for playlist. Is this intentional? |
reocat
pushed a commit
to reocat/OuterTune
that referenced
this pull request
Jan 6, 2025
* songs: centralize SongListItem logic + select header also consider connection * songs: add play when offline logic (only play offline items) * songs: fix song selection when offline * app: Fix codestyle * refactor: move select logic to parent
reocat
pushed a commit
to reocat/OuterTune
that referenced
this pull request
Jan 6, 2025
* songs: centralize SongListItem logic + select header also consider connection * songs: add play when offline logic (only play offline items) * songs: fix song selection when offline * app: Fix codestyle * refactor: move select logic to parent
What do you mean exacly? Multiselect in history should be like any other place. If a song is available (curently have connection or is downloaded) should be selectable. |
|
I tested it again, and when offline it's not selectable across the board. I'm not sure if it's a issue after merging, however in it's current state, it's something like this
|
|
It's not a bug, it's intentional, because the actions you can do with songs don't work when offline (like, add to library, playlist, download, play ...) |
reocat
pushed a commit
to reocat/OuterTune
that referenced
this pull request
Jan 8, 2025
* songs: centralize SongListItem logic + select header also consider connection * songs: add play when offline logic (only play offline items) * songs: fix song selection when offline * app: Fix codestyle * refactor: move select logic to parent
|
Ah, ok. All good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.