Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

innertube: simplify useLoginForBrowse #193

Merged
merged 1 commit into from
Jan 6, 2025
Merged

innertube: simplify useLoginForBrowse #193

merged 1 commit into from
Jan 6, 2025

Conversation

gechoto
Copy link
Contributor

@gechoto gechoto commented Jan 6, 2025 •
edited
Loading

What is it?

  • New feature (user facing)
  • Update to existing feature (user facing)
  • Bugfix (user facing)
  • Translations
  • Codebase improvements or refactors (dev facing)
  • Other

Description of the changes in your PR

  • less code
  • closer matches the description of the feature
  • matches what InnerTune and the official client does

Fixes the following issue(s)

Due diligence

  • I read the contribution guidelines.
  • I understand that in the event of merge conflicts, I may be asked to rebase my branch on top of the dev branch, instead of resolving them by merging dev into my own branch

@mikooomich mikooomich merged commit 06bd0cf into DD3Boh:dev Jan 6, 2025
1 check passed
@mikooomich
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit of premium only albums PR missing
2 participants
@gechoto @mikooomich