[Feature] 크리스마스 보드, 폴라로이드 테마 추가, Google Tag Manager 설정 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseublim
reviewed
Dec 15, 2024
src/lib/constants/polaroidConfig.ts
Outdated
| @@ -13,6 +13,50 @@ export const THEMAS: Record<ThemaKeyType, ThemaType> = { | |||
| descriptionStyle: | |||
| 'linear-gradient(180deg, rgba(255, 255, 255, 0.20) 10.71%, rgba(255, 255, 255, 0.50) 57.96%, rgba(255, 255, 255, 0.00) 100%), #eaeaea', | |||
| }, | |||
| 'F-12': { | |||
There was a problem hiding this comment.
여기 순서는 lint가 자동으로 한건가요? 아니라면 0부터 순서대로되면 좋을것 같습니다!
There was a problem hiding this comment.
디자인팀에서 정해준 폴라로이드 순서가 변경돼서 이렇게 바꿨는데, 순서대로 하려면 파일 이름을 모두 변경해야 합니다. 더 좋은 방법이 있을까요??
There was a problem hiding this comment.
아 순서때문에 그런거군요. 순서가 중요하다면 Object.entries 대신 보여줄 테마 키값을 별도의 배열로 관리하는게 나을 것 같은데 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 관련 이슈
크리스마스
✨ 작업한 내용
🌀 PR Point
고칠 부분이 있으면 알려주세요!
🍰 참고사항
NEXT_PUBLIC_GTM_ID 추가해주세요 디스코드에 있습니다!
📷 스크린샷 또는 GIF