Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change public-facing name of "Mass/Office" to "Service" #1367

Closed
dchiller opened this issue Mar 18, 2024 · 2 comments · Fixed by #1400
Closed

Change public-facing name of "Mass/Office" to "Service" #1367

dchiller opened this issue Mar 18, 2024 · 2 comments · Fixed by #1400
Assignees
Labels
enhancement New feature or request priority: high

Comments

@dchiller
Copy link
Contributor

A chant's "Mass/Office" field should become "Service". (This is a user-facing change...the underlying database field need not necessarily change).

From Debra:

Here are the places I see it:
https://cantusdatabase.org/chant-search/
https://cantusdatabase.org/offices/
Terms menu drop-down
the title and the first column of https://cantusdatabase.org/offices/
on the Create Chant page: https://cantusdatabase.org/chant-create/588309 (for example)
the header here: https://cantusdatabase.org/source/588309/inventory/ (for example)

Tagging @annamorphism for any additional areas where this shows up.

We'll also need to update our own documentation about this field.

@dchiller dchiller added enhancement New feature or request priority: medium labels Mar 18, 2024
@annamorphism
Copy link

A chant has it both on view and create!
Possibly the actual description of "Unknown Office (à déterminer)" should say "service" as well, though this category is being phased out anyway I think.
It's a bit weird that the URL says /offices but leads to an explanation of "services"--do we care?

@jacobdgm
Copy link
Contributor

To be consistent, I feel we should update the paths as well - /office/<id> should become /service/<id>, with all the necessary redirects set up to ensure things are backwards compatible.

It may be worth looking into changing things in the code as well, to minimize developer confusion. OfficeListView can easily be renamed ServiceListView, but I'm not sure how much trouble would arise if we renamed the model itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants