We should change all instances of "office" in the codebase with "service" #1402
Labels
Comments
jacobdgm
added
priority: low
maintainability
lucasmarchd01
added a commit
to lucasmarchd01/CantusDB
that referenced
this issue
Aug 7, 2024
… use 'service' instead of 'office'. - change all URL paths to use 'service/services'. DDMAL#1401 - create redirects to ensure backwards compatibility with old 'office/offices' URLs. DDMAL#1401 - update query parameters to use 'service' instead of 'office'. DDMAL#1401 - rename the Office model to Service. DDMAL#1402 - rename .office property of BaseChant to .service. DDMAL#1402 - change all instances of 'office' to 'service' in the codebase. DDMAL#1402 - update all references to 'office' to 'service' on the Django admin pages. DDMAL#1581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A follow-on to #1367 - at some point, it would be a good idea to go through the code base and change everything currently referring to "office" and "offices" -> "service"/"services"
In the long run, this will save developer time, both for on-boarding, but also for people not having to check whether any particular variable/property is called
officeorservice.This will necessitate a number of changes to our models - the
Officemodel will need to be renamedServiceand the.officeproperty of BaseChant will need to be renamed.service.The text was updated successfully, but these errors were encountered: