Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: A follow-up to the source rework #1566

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

ahankinson
Copy link
Member

This is a follow-up on the source / institution re-work.

  • There were a few places where the source siglum was still being used, so I fixed this. I'll keep looking.
  • Optimized some admin queryset with select_related
  • The check for what groups a user was in was triggering several SQL queries. A new template filter was added that takes a comma-separated string and uses that in a single filter() query.
  • The source browse chants view was doing a lot of work before a simple check that would trigger a 404. This check was moved up and simplified (It no longer checks the queryset with in but just checks the segment id matches the expected one).
  • The pagination custom tags were also slowing down the page loads, so they were optimized as well.

@dchiller
Copy link
Contributor

@ahankinson Looks good! Realize you didn't explicitly request review yet so lmk if this is good to merge or I was premature...

@ahankinson
Copy link
Member Author

Yeah a merge is okay.

@dchiller dchiller merged commit d3094fb into develop Jul 17, 2024
1 check passed
@dchiller dchiller deleted the source-cleanup-followup branch July 17, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants