New: Add views for institutions #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds views for institutions, giving them each their own page on the Cantus site. Special care was taken to get the source counts and source links correct for logged in / not logged in users and published / unpublished sources. In addition external authorities are shown -- currently only RISM Online entries are in the external authorities, but others can be added. An entry for DIAMM as an external authority was also added so that links between Cantus and DIAMM are possible.
|
Great! Could you include screenshots of these new views? |
|
Here's the entry for the Baviarian State Library:
Here's the list of all institutions:
|
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds views for institutions, giving them each their own page on the Cantus site.
Special care was taken to get the source counts and source links correct for logged in / not logged in users and published / unpublished sources.
In addition external authorities are shown -- currently only RISM Online entries are in the external authorities, but others can be added. An entry for DIAMM as an external authority was also added so that links between Cantus and DIAMM are possible.