Bug Fix: endpoint.hpp Change default listen backlog from 0 to socket_base::max_connections #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base::max_connections.
* The default value is specified as *::asio::socket_base::max_connections
* which uses the operating system defined maximum queue length. Your OS
* may restrict or silently lower this value. A value of zero may cause
* all connections to be rejected.
|
This bug causes connections to be rejected when UFW is enabled on Ubuntu 16.04, it's been reported and resolved on: zaphoyd@0bb33e4 I have tested it myself, and is working flawlessly 💯 |
|
you are welcome 👍 thx for making this into a pull request. I am curious if it will be pulled in or DecentFoundation waits for 0.8 release of WebsocketPP, e.g. Steem will wait for 0.8 WebsocketPP to come out. |
ejossev
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which uses the operating system defined maximum queue length. Your OS
may restrict or silently lower this value. A value of zero may cause
all connections to be rejected.