Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Update on 2017-12-15 #179

Merged
merged 5 commits into from
Dec 15, 2017
Merged

Conversation

deppbot
Copy link
Contributor

@deppbot deppbot commented Dec 14, 2017

Updated RubyGems:

--

Brought to you by deppbot - Automated Security and Dependency Updates
27 Pull Requests sent and 25 minutes, and 57 seconds saved so far.

Feedback or Bug Reports? Please let us know via Email or GitHub Issues.

deppbot and others added 5 commits December 15, 2017 04:11
[Deppbot](https://www.deppbot.com/) has updated rubocop and this has caused a break in the build due to new errors being found.

The one cop we have had to disable is `Style/FormatStringToken` which was introduced in 0.49.0.

<rubocop/rubocop#3438>

The only issue its highlighting in the code is `strftime()`, and we feel the way we are using it is as expected so are choosing to disable this cop for now.
The people behind ThoughtBot have decided to change the name of this gem, which breaks build if we don't rename it in our code. This change updates the gem and the code to use the new name.
We didn't implement a rubocop fix properly. This change corrects that mistake.
@Cruikshanks Cruikshanks merged commit 0838e5d into develop Dec 15, 2017
@Cruikshanks Cruikshanks deleted the bundle-update-2017-12-15-041127 branch December 15, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants