handle not async

DEFRA · Jan 21, 2025 · 6e9739f · 6e9739f
1 parent d2f5d80
commit 6e9739f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/recurring-payments-job/src/__tests__/recurring-payments-processor.spec.js b/packages/recurring-payments-job/src/__tests__/recurring-payments-processor.spec.js
@@ -17,7 +17,7 @@ jest.mock('@defra-fish/connectors-lib', () => ({
 
 jest.mock('../services/govuk-pay-service.js', () => ({
   sendPayment: jest.fn(),
-  getPaymentStatus: jest.fn()
+  getPaymentStatus: jest.fn(() => Promise.resolve('Success'))
 }))
 
 describe('recurring-payments-processor', () => {

diff --git a/packages/recurring-payments-job/src/recurring-payments-processor.js b/packages/recurring-payments-job/src/recurring-payments-processor.js
@@ -104,8 +104,9 @@ const processRecurringPaymentStatus = async record => {
   const referenceNumber = record.expanded.activePermission.entity.referenceNumber
   const paymentId = getPaymentId(referenceNumber)
   console.log('Checking payment status for', paymentId)
-  const status = await getPaymentStatus(paymentId)
-  console.log(`Payment status for ${paymentId}: ${status}`)
+  getPaymentStatus(paymentId).then(status => {
+    console.log(`Payment status for ${paymentId}: ${status}`)
+  })
 }
 
 const getPaymentId = referenceNumber => {

diff --git a/packages/recurring-payments-job/src/services/govuk-pay-service.js b/packages/recurring-payments-job/src/services/govuk-pay-service.js
@@ -4,6 +4,6 @@ export const sendPayment = preparedPayment => {
   govUkPayApi.createPayment(preparedPayment, true)
 }
 
-export const getPaymentStatus = async paymentId => {
+export const getPaymentStatus = paymentId => {
   govUkPayApi.fetchPaymentStatus(paymentId, true)
 }