Initial setup RP job #1769
Merged
Initial setup RP job #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3381 Setup recurring payment job
irisfaraway
requested changes
Aug 14, 2023
| @@ -0,0 +1,8 @@ | |||
| The Open Government Licence (OGL) Version 3 | |||
|
|
|||
| Copyright (c) 2020 DEFRA | |||
There was a problem hiding this comment.
Should this be 2023 since that's when we're adding it? Not sure tbh!
There was a problem hiding this comment.
Let's check with a Principal Dev on this
There was a problem hiding this comment.
I will message Ben
| @@ -70,6 +70,7 @@ packages/ | |||
| > Handles processing of post-office counter sales | |||
| - [fulfilment-job](packages/fulfilment-job/README.md) | |||
| > Handles processing of licence fulfilment requirements | |||
| - [recurring-payments-job](packages/recurring-payments-job/README.md) | |||
There was a problem hiding this comment.
Can we also have a line of description of what the job does, like the others do above?
irisfaraway
approved these changes
Aug 29, 2023
jaucourt
approved these changes
Sep 15, 2023
ScottDormand96
added a commit
that referenced
this pull request
Jan 3, 2024
* Feature branch rp job * Initial setup RP job (#1769) * Initial setup RP job https://eaflood.atlassian.net/browse/IWTF-3381 Setup recurring payment job * initial setup * Update docker/README.md Co-authored-by: Iris Faraway <[email protected]> * update readme * update license * add console log for when rp running * setup docker so picks up commands run tomprove running * LICENSE --------- Co-authored-by: Iris Faraway <[email protected]> * Retrieve recurring payments https://eaflood.atlassian.net/browse/IWTF-3617 Recurring Payments Job to retrieve the recurring payments due on the current day * grab rp * working rpjob * update error in tranaction.schema * prettier readme * remove console logs * Updated following comments in PR, pushing to fix test * Update dependencies, fix lint errors * push changes for support * update getRecurringPayments * updated env files, remove logs, add date, refactor tests * lint errors * code smells * remove console logs * fix broken test * fix code smell * remove await * code coverage * update tests and package.json * npm install on rp job folder * remove package-lock and run npm install * update package-lock and package references * changes made following pr comments * update package.json * update entity tests, add comments where changes are needed * Amend so that we expand contact and active permission in a single fetc h, plus filter just on date when retrieving recurring payments * Fixed process transaction queue tests * Fix recurring payment service tests * Update dependencies * Fix more dependencies * Dependencies. Yeah. * new version of recurring-payments-job * Update package lock for recurring payments job * Remove automock and add manual mock to work around weird failure * Fix RP query test * Fix code smell * Remove phone from content in text message option (#1826) * Remove phone from content in text message option https://eaflood.atlassian.net/browse/IWTF-3861 Remove the word phone from the content for a text message option * added welsh * chore(release): publish v1.37.0-rc.7 * rename tests, change date format and update tests * remove mockRestore --------- Co-authored-by: Iris Faraway <[email protected]> Co-authored-by: Phil Benson <[email protected]> Co-authored-by: GitHub Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3381
Setup recurring payment job