Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activity in CRM #2091

Merged
merged 3 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createActivity } from '../activity.queries.js'
import { createActivity, updateActivity } from '../activity.queries.js'
import { dynamicsClient } from '../../client/dynamics-client.js'

jest.mock('dynamics-web-api', () => {
Expand Down Expand Up @@ -69,4 +69,63 @@ describe('Activity Service', () => {
})
})
})

describe('updateActivity', () => {
const mockResponse = {
'@odata.context': 'https://dynamics.om/api/data/v9.1/defra_UpdateRCRActivityResponse',
ReturnStatus: 'success',
SuccessMessage: 'RCR Activity - updated successfully',
ErrorMessage: null,
oDataContext: 'https://dynamics.com/api/data/v9.1/defra_UpdateRCRActivityResponse'
}

const errorResponse = {
'@odata.context': 'https://dynamics.om/api/data/v9.1/defra_UpdateRCRActivityResponse',
RCRActivityId: null,
ReturnStatus: 'error',
SuccessMessage: '',
ErrorMessage: 'Failed to update activity',
oDataContext: 'https://dynamics.com/api/data/v9.1/defra_UpdateRCRActivityResponse'
}

jaucourt marked this conversation as resolved.
Show resolved Hide resolved
it('should call dynamicsClient with correct parameters', async () => {
dynamicsClient.executeUnboundAction.mockResolvedValue(mockResponse)

await updateActivity('contact-identifier-123', 2023)

expect(dynamicsClient.executeUnboundAction).toHaveBeenCalledWith('defra_UpdateRCRActivity', {
ContactId: 'contact-identifier-123',
ActivityStatus: 'SUBMITTED',
Season: 2023
})
})

it('should return the CRM response correctly', async () => {
dynamicsClient.executeUnboundAction.mockResolvedValue(mockResponse)

const result = await updateActivity('contact-identifier-123', 2024)

expect(result).toEqual(mockResponse)
})

it('should handle error in dynamicsClient response', async () => {
const error = new Error('Failed to update activity')
dynamicsClient.executeUnboundAction.mockRejectedValue(error)

await expect(updateActivity('contact-identifier-123', 2024)).rejects.toThrow('Failed to update activity')
})

it('should handle the case where activity creation fails', async () => {
dynamicsClient.executeUnboundAction.mockResolvedValue(errorResponse)

const result = await updateActivity('invalid-contact-id', 2024)

expect(result).toMatchObject({
RCRActivityId: null,
ReturnStatus: 'error',
SuccessMessage: '',
ErrorMessage: 'Failed to update activity'
})
})
})
})
23 changes: 23 additions & 0 deletions packages/dynamics-lib/src/queries/activity.queries.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,26 @@ export const createActivity = (contactId, season) => {

return dynamicsClient.executeUnboundAction('defra_CreateRCRActivity', request)
}

/**
* Updates an RCR Activity in Microsoft Dynamics CRM.
*
* @param {string} contactId - The ID of the contact associated with the activity.
* @param {number} season - The season year for which the activity is being created.
* @returns {Promise<Object>} - A promise that resolves to the response from Dynamics CRM.
* @property {string} [email protected] - The OData context URL of the response.
* @property {string} response.RCRActivityId - The unique identifier of the created RCR activity.
* @property {string} response.ReturnStatus - The status of the activity creation operation (e.g., 'success').
* @property {string} response.SuccessMessage - A message indicating successful creation of the activity.
* @property {string|null} response.ErrorMessage - An error message if the activity creation failed, otherwise null.
* @property {string} response.oDataContext - The OData context URL of the response.
*/
export const updateActivity = (contactId, season) => {
const request = {
ContactId: contactId,
ActivityStatus: 'SUBMITTED',
Season: season
}

return dynamicsClient.executeUnboundAction('defra_UpdateRCRActivity', request)
}
Loading