Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalising Date Entry Fields #2106

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

lailien3
Copy link
Contributor

https://eaflood.atlassian.net/browse/IWTF-4393

Date entry fields are currently all in lower case across the service. They should begin capitalised.

@lailien3 lailien3 added the bug Something isn't working label Dec 24, 2024
@lailien3 lailien3 self-assigned this Dec 24, 2024
Copy link
Collaborator

@jaucourt jaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally not your fault, but I think the labels here could be better. I think they should be date_day, date_month and date_year, as they're not only used for date of birth but licence start date too. Also, is the Welsh capitalised? If not, should we do it in this ticket?

Copy link

sonarqubecloud bot commented Jan 8, 2025

@lailien3
Copy link
Contributor Author

lailien3 commented Jan 8, 2025

Totally not your fault, but I think the labels here could be better. I think they should be date_day, date_month and date_year, as they're not only used for date of birth but licence start date too. Also, is the Welsh capitalised? If not, should we do it in this ticket?

good shout 👍🏼 Welsh is already capitalised 🕺🏼

@lailien3 lailien3 merged commit d708def into develop Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants