Implement fail screen for easy renewals journey Part 1 #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lailien3
force-pushed
the
feature/iwtf-4393-implement-fail-screen-easy-renewals
branch
from
5433118 to
7ad115b
Compare
|
lailien3
deleted the
feature/iwtf-4393-implement-fail-screen-easy-renewals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4392
The easy renewals journey is using error validation to tell a user they are not eligible to use the service (in this case because their details do not match any in our systems). This is not a correct use of the design pattern: Recover from validation errors
“Do not use validation to check whether the user is eligible to use the service”
Instead the user should be taken to a new screen that tells them what has happened and what they need to do next.