Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate pool show candidate #10404

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Candidate pool show candidate #10404

merged 1 commit into from
Feb 20, 2025

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Feb 20, 2025

Context

This is the show page for the candidate of a candidate pool.

The content is not complete and is subject to change due to UR.

Guidance to review

Go on review app as a provider and view a candidate in the candidate pool

Screenshot from 2025-02-20 11-29-22

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag changed the title wip Candidate pool show candidate Feb 20, 2025
@CatalinVoineag CatalinVoineag self-assigned this Feb 20, 2025
@CatalinVoineag
Copy link
Contributor Author

@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Feb 20, 2025
@CatalinVoineag CatalinVoineag marked this pull request as ready for review February 20, 2025 11:30
@github-actions github-actions bot temporarily deployed to review-10404 February 20, 2025 11:46 Destroyed
This is the show page for the candidate of a candidate pool.

The content is not complete and is subject to change due to UR.
@CatalinVoineag CatalinVoineag requested a review from a team February 20, 2025 12:14
@github-actions github-actions bot temporarily deployed to review-10404 February 20, 2025 12:21 Destroyed
@CatalinVoineag CatalinVoineag merged commit b6e2df5 into main Feb 20, 2025
26 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/candidate-pool-show branch February 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants