Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status to pool invite #10406

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Add status to pool invite #10406

merged 1 commit into from
Feb 20, 2025

Conversation

CatalinVoineag
Copy link
Contributor

Context

The invite form for a candidate to be invited by a provider to apply for a course will be DB backed, to make this work we need an enum to save the pool invite in a draft state before 'publishing' it after review step.

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

The invite form for a candidate to be invited by a provider to apply for
a course will be DB backed, to make this work we need an enum to save
the pool invite in a draft state before 'publishing' it after review
step.
@CatalinVoineag CatalinVoineag self-assigned this Feb 20, 2025
@CatalinVoineag CatalinVoineag requested a review from a team February 20, 2025 11:42
@CatalinVoineag CatalinVoineag marked this pull request as ready for review February 20, 2025 11:42
@CatalinVoineag
Copy link
Contributor Author

Copy link
Contributor

Database-level enum changes detected

Please include a data migration for these attributes and values:

0a1
> <enum> Pool::Invite.status: ["draft", "published"]

@CatalinVoineag CatalinVoineag merged commit a6f03c3 into main Feb 20, 2025
26 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/add-status-to-pool-invite branch February 20, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants