Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[653] Update review page titles and H1's on application form #10418

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

avinhurry
Copy link
Collaborator

@avinhurry avinhurry commented Feb 24, 2025

Context

We are updating the review page titles and H1's for consistency and to reflect the fact that the user is reviewing the information.

Changes proposed in this pull request

  • Update H1's on all the review pages of all the sections of the application.
  • Update page titles on all the review pages of all the sections of the application

See spreadsheet attached to the trello card for more details.

Guidance to review

Have a look through all of them on the review app.

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@avinhurry
Copy link
Collaborator Author

@avinhurry avinhurry added the deploy_v2 Deploy the review app to AKS label Feb 24, 2025
@github-actions github-actions bot temporarily deployed to review-10418 February 24, 2025 21:26 Destroyed
@avinhurry avinhurry force-pushed the 653-review-all-check-answers-pages-headings branch from 283f23c to c314921 Compare February 25, 2025 11:06
@github-actions github-actions bot temporarily deployed to review-10418 February 25, 2025 11:10 Destroyed
To reflect the fact that you are reviewing your answers
@avinhurry avinhurry force-pushed the 653-review-all-check-answers-pages-headings branch from c314921 to 64d8a4e Compare February 25, 2025 15:19
@avinhurry avinhurry marked this pull request as ready for review February 25, 2025 15:25
@avinhurry avinhurry requested a review from a team February 25, 2025 15:25
@github-actions github-actions bot temporarily deployed to review-10418 February 25, 2025 15:27 Destroyed
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change required, everything else is spot on 🧐

@github-actions github-actions bot temporarily deployed to review-10418 February 26, 2025 08:50 Destroyed
@avinhurry avinhurry merged commit 9b7bc4d into main Feb 26, 2025
25 checks passed
@avinhurry avinhurry deleted the 653-review-all-check-answers-pages-headings branch February 26, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants