Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[653] Miscellaneous fixes on the candidate interface #10425

Merged
merged 6 commits into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%= render(SummaryCardHeaderComponent.new(title: title(degree), heading_level: @heading_level)) do %>
<% if deletable? %>
<div class="app-summary-card__actions">
<%= govuk_link_to candidate_interface_confirm_degree_destroy_path(degree.id) do %>
<%= govuk_link_to candidate_interface_confirm_degree_destroy_path(degree.id), class: 'govuk-!-font-weight-bold' do %>
<%= t('application_form.degree.delete') %><span class="govuk-visually-hidden"><%= generate_action(degree: degree) %></span>
<% end %>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,19 @@ def ielts_rows
},
},
{
key: 'Year completed',
value: ielts_qualification.award_year,
key: 'Overall band score',
value: ielts_qualification.band_score,
action: {
href: candidate_interface_edit_ielts_path(return_to_params(return_to_application_review)),
visually_hidden_text: 'year completed',
visually_hidden_text: 'overall band score',
},
},
{
key: 'Overall band score',
value: ielts_qualification.band_score,
key: 'Year completed',
value: ielts_qualification.award_year,
action: {
href: candidate_interface_edit_ielts_path(return_to_params(return_to_application_review)),
visually_hidden_text: 'overall band score',
visually_hidden_text: 'year completed',
},
},
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<%= render(SummaryCardHeaderComponent.new(title: qualification.title, heading_level: @heading_level)) do %>
<% if deletable? %>
<div class="app-summary-card__actions">
<%= govuk_link_to candidate_interface_confirm_destroy_other_qualification_path(qualification.id) do %>
<%= govuk_link_to candidate_interface_confirm_destroy_other_qualification_path(qualification.id), class: 'govuk-!-font-weight-bold' do %>
<%= t('application_form.other_qualification.delete') %><span class="govuk-visually-hidden"><%= generate_action(qualification: qualification) %></span>
<% end %>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<ul class="app-summary-card__actions-list">
<% if deletable? && reference_editable?(reference) %>
<li class="app-summary-card__actions-list-item">
<%= govuk_link_to confirm_destroy_path(reference) do %>
<%= govuk_link_to confirm_destroy_path(reference), class: 'govuk-!-font-weight-bold' do %>
<%= t('application_form.references.delete_reference.action') %>
<span class="govuk-visually-hidden">reference from <%= reference.name %></span>
<% end %>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<%= render(SummaryCardHeaderComponent.new(title: volunteering_role.role, heading_level: @heading_level)) do %>
<% if deletable? %>
<div class="app-summary-card__actions">
<%= govuk_link_to candidate_interface_confirm_destroy_volunteering_role_path(volunteering_role.id) do %>
<%= govuk_link_to candidate_interface_confirm_destroy_volunteering_role_path(volunteering_role.id), class: 'govuk-!-font-weight-bold' do %>
<%= t('application_form.volunteering.delete.action') %><span class="govuk-visually-hidden"><%= generate_action(volunteering_role: volunteering_role) %></span>
<% end %>
</div>
Expand Down
2 changes: 1 addition & 1 deletion config/locales/candidate_interface/personal_details.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ en:
label: Do you have the right to work or study in the UK?
change_action: if you have the right to work or study in the UK
visa_or_immigration_status:
label: Visa or Immigration status
label: Visa or immigration status
change_action: visa or immigration status
immigration_status:
label: Immigration status
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def and_i_click_save_and_continue
end

def then_i_see_the_correct_visa_in_the_summary(visa_summary_text)
within '.govuk-summary-list__row', text: 'Immigration status' do
within '.govuk-summary-list__row', text: 'immigration status' do
expect(page).to have_text(visa_summary_text)
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def and_i_can_change_state_that_i_have_permanent_residence
expect(page).to have_content('Lando Calrissian')
expect(page).to have_content('Pakistani')
expect(page).to have_content('Do you have the right to work or study in the UK? Yes')
expect(page).to have_content('Immigration status I have permanent residence')
expect(page).to have_content('immigration status I have permanent residence')
end

def and_i_can_change_nationality_to_an_eu_country_with_settled_status
Expand All @@ -88,7 +88,7 @@ def and_i_can_change_nationality_to_an_eu_country_with_settled_status
expect(page).to have_current_path candidate_interface_personal_details_show_path
expect(page).to have_content('Nationality French')
expect(page).to have_content('Do you have the right to work or study in the UK? Yes')
expect(page).to have_content('Immigration status EU settled status')
expect(page).to have_content('immigration status EU settled status')
end

def and_i_can_change_immigration_status
Expand All @@ -99,7 +99,7 @@ def and_i_can_change_immigration_status
click_link_or_button t('save_and_continue')

expect(page).to have_current_path candidate_interface_personal_details_show_path
expect(page).to have_content('Immigration status EU pre-settled status')
expect(page).to have_content('immigration status EU pre-settled status')
end

def and_i_can_mark_the_section_complete
Expand Down
Loading